-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i.atcorr: Fix uninitialized variable #4022
Conversation
There was only one file left? |
yes in imagery folder there is only one cpp file left other files are c file. So now i am grouping folder wise and programming language wise |
Perfect! |
See the new error here (and build failure) (ignore the garbage of the html file, it seems like unsynced output of parallel tasks):
https://github.com/OSGeo/grass/actions/runs/9880555579/job/27289369496?pr=4022#step:8:8216 |
let me check i did the changes i think because it has two nested struct members it was not initializing everything. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This pull request addresses uninitialized variable issue for all cpp files in imagery
Issue:
i.atcorr/main.cpp:213:16: error: Uninitialized variable: rbitem.ti [uninitvar]
return rbitem;
Changes Made:
Initialized the RBitem struct to zero to ensure all members, including nested structures, are properly initialized.