man: fix KeyError: 'MDDIR' in man/build_md.py #4739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At time the GRASS GIS main compilation with addons with `cron_grass_preview_build_binaries.sh` is broken: https://grass.osgeo.org/grass85/binary/linux/snapshot/build.log.txt ``` ... Parsing <v.what.strds.timestamp>... SUCCESS Parsing <wx.metadata>... FAILED Parsing <wx.mwprecip>... FAILED Parsing <wx.stream>... FAILED Parsing <wx.wms>... FAILED + cp /home/neteler/.grass8/addons/modules.xml /var/www/code_and_data/addons/grass8/modules.xml + export ARCH + export ARCH_DISTDIR=/home/neteler/src//main/dist.x86_64-pc-linux-gnu + export GISBASE=/home/neteler/src//main/dist.x86_64-pc-linux-gnu + export VERSION_NUMBER=8.5 + python3 /home/neteler/src//main/man/build_keywords.py /var/www/code_and_data/grass85/manuals/ /var/www/code_and_data/grass85/manuals/addons/ Traceback (most recent call last): File "/home/neteler/src//main/man/build_keywords.py", line 202, in <module> build_keywords("md") File "/home/neteler/src//main/man/build_keywords.py", line 68, in build_keywords from build_md import ( File "/home/neteler/src/main/man/build_md.py", line 264, in <module> man_dir = os.path.join(os.environ["MDDIR"], "source") File "/usr/lib/python3.9/os.py", line 679, in __getitem__ raise KeyError(key) from None KeyError: 'MDDIR' ``` This PR attemps to fix this bug (inspired by `man/build_html.py`). Tested on grass.osgeo.org (without log file).
landam
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At time the GRASS GIS main compilation with addons with
cron_grass_preview_build_binaries.shis broken:https://grass.osgeo.org/grass85/binary/linux/snapshot/build.log.txt
This PR attemps to fix this bug (inspired by
man/build_html.py). Tested on grass.osgeo.org (without log file).Originally reported in OSGeo/grass-addons#1241 (comment)