Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: Update DB.make for markdown support #4742

Merged
merged 5 commits into from
Nov 23, 2024
Merged

Conversation

landam
Copy link
Member

@landam landam commented Nov 22, 2024

This PR fixes #4740 (comment)

Note that links remain broken if GRASS is not built with specific driver support. See broken MySQL links in https://grass.osgeo.org/grass84/manuals/databaseintro.html#creating-a-database. This issue should be addressed by separated PR or at least reported as GitHub issue.

@landam landam changed the title Update DB.make for markdown support build: Update DB.make for markdown support Nov 23, 2024
@landam landam changed the title build: Update DB.make for markdown support make: Update DB.make for markdown support Nov 23, 2024
neteler
neteler previously approved these changes Nov 23, 2024
Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it solves the problem (tested locally).

@landam landam added the docs label Nov 23, 2024
@neteler
Copy link
Member

neteler commented Nov 23, 2024

Seems we have a chicken-egg problem here (need to have the .md files in place to make the CI happy):

CI log:

make[3]: Entering directory '/home/runner/work/grass/grass/db/drivers'
make -C dbf || echo /home/runner/work/grass/grass/db/drivers/dbf >> /home/runner/work/grass/grass/error.log
make -C sqlite || echo /home/runner/work/grass/grass/db/drivers/sqlite >> /home/runner/work/grass/grass/error.log
make -C ogr || echo /home/runner/work/grass/grass/db/drivers/ogr >> /home/runner/work/grass/grass/error.log
make[4]: Entering directory '/home/runner/work/grass/grass/db/drivers/sqlite'
test -d OBJ.x86_64-pc-linux-gnu || mkdir -p OBJ.x86_64-pc-linux-gnu
make[4]: *** No rule to make target '/home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/docs/mkdocs/source/grass-sqlite.md', needed by 'db_html'.  Stop.
make[4]: *** Waiting for unfinished jobs....
make[4]: Entering directory '/home/runner/work/grass/grass/db/drivers/ogr'
test -d OBJ.x86_64-pc-linux-gnu || mkdir -p OBJ.x86_64-pc-linux-gnu
make[4]: Entering directory '/home/runner/work/grass/grass/db/drivers/dbf'
test -d OBJ.x86_64-pc-linux-gnu || mkdir -p OBJ.x86_64-pc-linux-gnu
make[4]: *** No rule to make target '/home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/docs/mkdocs/source/grass-ogr.md', needed by 'db_html'.  Stop.
make[4]: *** Waiting for unfinished jobs....
make[4]: Leaving directory '/home/runner/work/grass/grass/db/drivers/sqlite'
make[4]: *** No rule to make target '/home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/docs/mkdocs/source/grass-dbf.md', needed by 'db_html'.  Stop.
make[4]: *** Waiting for unfinished jobs....

@landam
Copy link
Member Author

landam commented Nov 23, 2024

Seems we have a chicken-egg problem here (need to have the .md files in place to make the CI happy):

Yes, we have to comment it similarly as we did for other markdown-related rules: 6743f1a. They can be enabled in PR which adds markdown files.

Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@landam landam merged commit ab67825 into OSGeo:main Nov 23, 2024
26 checks passed
@github-actions github-actions bot added this to the 8.5.0 milestone Nov 23, 2024
@landam landam deleted the db_make_md branch November 23, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants