Implement application health check and hpa #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ashwani-opstree
commented
Jul 5, 2024
ashwani-opstree
commented
- Health Probes (Readiness and Liveness)
- Horizontal Pod Autoscaling (Memory and CPU)
sandy724
requested changes
Jul 5, 2024
charts/microservice/values.yaml
Outdated
| # -- global variables | ||
| global: | ||
| replicaCount: 1 | ||
| fullnameOverride: "nginx" |
There was a problem hiding this comment.
nginx can't be a default option
Yes i changed it.
charts/microservice/values.yaml
Outdated
| # -- Override default container image format | ||
| image: | ||
| # -- Image repository | ||
| repository: "nginx" |
There was a problem hiding this comment.
repository -> name
Yes i changed it.
charts/microservice/values.yaml
Outdated
| # -- Image tag | ||
| tag: "latest" | ||
| # -- Variable used to control when the image should be fetched | ||
| pullPolicy: always |
There was a problem hiding this comment.
should be PullIfNotPresent
Yes i changed it.
charts/microservice/values.yaml
Outdated
| # -- Variable used to control when the image should be fetched | ||
| pullPolicy: always | ||
| # -- Definition of the liveness probe | ||
| livenessProbe: |
There was a problem hiding this comment.
Should be optional
Can we have a warning mentioning this should have been present
Yes i changed it.
| @@ -0,0 +1,27 @@ | |||
| {{- if .Values.hpa }} | |||
| apiVersion: autoscaling/v2beta1 | |||
There was a problem hiding this comment.
Support for multiple k8s versions
Yes i changed it.
| - type: Resource | ||
| resource: | ||
| name: cpu | ||
| targetAverageUtilization: {{ default 50 .Values.hpa.targetAverageCPUUtilization }} |
There was a problem hiding this comment.
remove hard coding
Yes i changed it.
| imagePullPolicy: {{ .Values.image.pullPolicy }} | ||
| - name: {{ include "microservice.fullname" . }} | ||
| image: "{{ .Values.deployment.image.repository }}:{{ .Values.deployment.image.tag }}" | ||
| imagePullPolicy: {{ .Values.deployment.image.pullPolicy | default "IfNotPresent" }} |
There was a problem hiding this comment.
Should have been solved by default value
Yes i changed it.
| ports: | ||
| - name: http | ||
| containerPort: 80 | ||
| protocol: TCP | ||
| {{- if .Values.deployment.livenessProbe }} |
There was a problem hiding this comment.
Move probes to separate sections
Yes i changed it.
ashwani-opstree
force-pushed
the
ms-health-check
branch
2 times, most recently
from
de39c68 to
41973a4
Compare
Signed-off-by: Ashwani Singh <[email protected]>
ashwani-opstree
force-pushed
the
ms-health-check
branch
from
ddd9974 to
fff0b8a
Compare
Signed-off-by: Ashwani Singh <[email protected]>
Signed-off-by: Ashwani Singh <[email protected]>
Signed-off-by: Ashwani Singh <[email protected]>
Signed-off-by: Ashwani Singh <[email protected]>
Signed-off-by: Ashwani Singh <[email protected]>
Signed-off-by: Ashwani Singh <[email protected]>
Signed-off-by: Ashwani Singh <[email protected]>
Signed-off-by: Ashwani Singh <[email protected]>
Signed-off-by: Ashwani Singh <[email protected]>
Signed-off-by: Ashwani Singh <[email protected]>
Signed-off-by: Ashwani Singh <[email protected]>
Signed-off-by: Ashwani Singh <[email protected]>
Signed-off-by: Ashwani Singh <[email protected]>
Signed-off-by: Ashwani Singh <[email protected]>
ashwani-opstree
force-pushed
the
ms-health-check
branch
from
88f9f3f to
334cd43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.