Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed certificate serverName to pod+namespace #1221

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

MuhammadQadora
Copy link
Contributor

@MuhammadQadora MuhammadQadora commented Jan 28, 2025

Description

Changed podName to podName.namespace in the tls.config in secrets.go so that is it possible to issue *.namespace wildcard TLS certificate with cert-manager.

Fixes #763
Type of change

  • Bug fix (non-breaking change which fixes an issue)
    Checklist
  • Tests have been added/modified and all tests pass.
  • [*] Functionality/bugs have been confirmed to be unchanged or fixed.
  • [*] I have performed a self-review of my own code.
  • [*] Documentation has been updated or added where necessary.

Additional Context

@drivebyer drivebyer merged commit 8fbb4f7 into OT-CONTAINER-KIT:master Feb 1, 2025
13 of 14 checks passed
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.64%. Comparing base (60ef5a2) to head (caa22eb).
Report is 36 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1221      +/-   ##
==========================================
- Coverage   30.20%   29.64%   -0.56%     
==========================================
  Files          55       57       +2     
  Lines        6294     6658     +364     
==========================================
+ Hits         1901     1974      +73     
- Misses       4200     4498     +298     
+ Partials      193      186       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants