Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update status if not equal #900

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

drivebyer
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 39.88%. Comparing base (d121d86) to head (6cc1fcb).
Report is 32 commits behind head on master.

Files Patch % Lines
k8sutils/status.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
+ Coverage   35.20%   39.88%   +4.68%     
==========================================
  Files          19       19              
  Lines        3213     2660     -553     
==========================================
- Hits         1131     1061      -70     
+ Misses       2015     1528     -487     
- Partials       67       71       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer requested a review from shubham-cmyk April 26, 2024 08:49
Copy link
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drivebyer drivebyer merged commit 40c4a0d into OT-CONTAINER-KIT:master Apr 26, 2024
28 of 29 checks passed
@drivebyer drivebyer deleted the fix-update-status branch April 26, 2024 09:08
@drivebyer drivebyer added the enhancement New feature or request label May 13, 2024
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants