Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed text wrapping in editable text windows #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jonekk
Copy link
Contributor

@Jonekk Jonekk commented Nov 4, 2024

Hello, first time contributor here. Im not fluent with otcv8 codebase, I have no broad knowledge about the impact of such change. Please let me know if there's more to be taken care of in such change

presentation.webm

@Jonekk Jonekk force-pushed the fix-edit-text-wrapping branch from adf51de to e8e8ce6 Compare November 4, 2024 09:39
@Oen44
Copy link
Collaborator

Oen44 commented Nov 4, 2024

Even ignoring that you didn't follow codebase styling convention, getDrawTextPosForTextPos executing every frame is not right, this should be cached. A lot of looping in this new code, fortunately most of them is in recaching. Also remove that text-wrap from bugreport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants