Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display big items in UI more conviniently #18

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

Jonekk
Copy link
Contributor

@Jonekk Jonekk commented Nov 5, 2024

Before:
Screenshot from 2024-11-04 23-13-40
After:
Screenshot from 2024-11-04 23-12-23
Wand of decay corner case (still better than it was):
backpack_show.webm

@Oen44
Copy link
Collaborator

Oen44 commented Nov 5, 2024

Nah, it makes them too small and harder to see. Also it probably glitched all animated items and not just wand of decay?

@Jonekk
Copy link
Contributor Author

Jonekk commented Nov 5, 2024

Nah, it makes them too small and harder to see. Also it probably glitched all animated items and not just wand of decay?

Are you sure you're looking at pictures correctly? After this change items will be much larger than before (2 or 4 times larger, filling the 32x32 box)
Also wand of decay was glitched way more. There is one frame that has 34px height, so it looked correctly for most frames, but for one of them it was getting shrinked to 1/4 size. Now there is just small glitch resulting from resizing 34px to 32px

@Oen44
Copy link
Collaborator

Oen44 commented Nov 5, 2024

Nah, it makes them too small and harder to see. Also it probably glitched all animated items and not just wand of decay?

Are you sure you're looking at pictures correctly? After this change items will be much larger than before (2 or 4 times larger, filling the 32x32 box) Also wand of decay was glitched way more. There is one frame that has 34px height, so it looked correctly for most frames, but for one of them it was getting shrinked to 1/4 size. Now there is just small glitch resulting from resizing 34px to 32px

Oh wow, I actually got it the other way around, you are right. Also what the hell? WoD has 34px frame? Cipsoft, why...

@Jonekk
Copy link
Contributor Author

Jonekk commented Nov 5, 2024

Sadly, yes. This is how wod looks atm (before this change):
Screencast from 05.11.2024 01:31:23.webm
one frame that is 34px long:
Screenshot from 2024-11-05 01-31-44

@Feeltz
Copy link

Feeltz commented Nov 5, 2024

In the OG Cipsoft client it looks like in this PR, so sprites are stretched to the "item box".

@Oen44 Oen44 merged commit d20e8e1 into OTAcademy:master Nov 6, 2024
0 of 4 checks passed
Oen44 added a commit that referenced this pull request Nov 18, 2024
This reverts commit d20e8e1.

Unfortunately this breaks drawing UI items of custom widget sizes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants