Compile issues in linux, missing <sting> import
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tornadia
commented
Dec 29, 2024
tornadia
commented
- Fixes compile issue on linux
- Fixes compile issue on linux
|
On Ubuntu 22.04 client compiles without errors, no need to add this include. What distro are you running? |
In ArchLinux for example, it does also require that we include std::string in stats.h, same occurs with Fedora 41. |
jordanhoare
added a commit
to tibia-oce/otclientv8
that referenced
this pull request
Jan 16, 2025
* Fix deletion of the hotkey opening keybind * Fix UIWidget::updateRectToWord argument typo * Fixed typo in vcpkg triplet for Win32 Debug * Renamed struct Graph in UIGraph This fixes debugging with Visual Studio * Typos fixed in VS project configuration * Update stats.h (OTAcademy#33) Fixes compilation errors on some Linux distros * Delete walking keybinds on terminate Closes OTAcademy#36 * Rebind walking after module is loaded while in game Closes OTAcademy#36 * chore: swap cmake to premake (#18) * fix: uiwidget::updaterecttoword argument typo * chore: renamed struct Graph in UIGraph * chore: fix imports * chore: delete walking keybinds on terminate * housekeeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.