Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DataBaseServer.java #270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nesterXneo
Copy link

Improvements that were made:

  • Removed unused imports and parameters.
  • Added a logger for proper error logging.
  • Introduced a DatabaseService for dependency injection of database operations.
  • Improved error handling in the getAll method.
  • Used try-with-resources for automatic resource management.
  • Removed the unused main method.
  • Standardized error responses.
  • Added a constant for the "Not Implemented" message.

@davewichers
Copy link
Contributor

@nesterXneo - There are build errors in this AND the code has not been run through Spotless, so you need to fix the code too before submitting it. If you run mvn clean compile, it should reformat your code for you automatically and then you should submit the reformatted code instead.

@davewichers
Copy link
Contributor

@nesterXneo - Are you going to fix your pull request? If I don't hear back from you in a while, I'm going to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants