Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom sonarqube generation with sonar-report #286

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

darkspirit510
Copy link
Contributor

@darkspirit510 darkspirit510 commented Jan 28, 2025

As discussed with @davewichers, I replaced custom report generation with sonar-report. Important: BenchmarkUtils requires PR 152 to be merged, because one field got removed which is expected to be present leading to zero results in score.

Recreated PR. Forgot to pull main 😅

@davewichers davewichers merged commit fdfe560 into OWASP-Benchmark:master Jan 28, 2025
4 checks passed
@darkspirit510 darkspirit510 deleted the sonar-report-new branch January 28, 2025 15:18
@davewichers
Copy link
Contributor

@darkspirit510 - I merged this, but (per my emails) there are two issues with it:

  1. The score for SonarQube is lower than the previous script, due to it isn't pulling the Weak Hashing results at all, and some of the Weak Encryption results too. Or those results aren't being generated because maybe the rules are off?
  2. We were hoping this would work on Windows too, but I get error running this on Windows (but have no problem installing on Mac):
    npm install -g sonar-report
    npm error Maximum call stack size exceeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants