-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created ChapterDetails Component #544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. Some comments ⬇️
@Rajgupta36 sorry it took me a moment to get back to this one! Could you resolve conflicts? I'll review it as soon as that's ready to view! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we need to be smarter here in a long-term perspective. How about creating a generic entity details page component (like the Card
we have for projects/chapters/committees) that could be reused for any entity depending on the fields passed to the function. So here and for committee details page too we'd just use the same code.
@Rajgupta36 does it make sense?
We could use a generic component, but putting all logic into a single file might make things more complex. Would it be better to make it modular? Perhaps we can use two generic components and handle some features like the map (ChapterPage) and issues/releases (ProjectPage) in their respective pages. What do you think, @arkid15r and @kasya ? |
Should I do this in this PR, @arkid15r? |
Up to you, we can merge this one but it'll require more refactoring then. |
Okay, I completed this in a few minutes and created an issue (like the test cases earlier). |
@kasya It’s ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge it as is -- we're going to unify it from the code reuse perspective.
Thanks for adding this @Rajgupta36!
Resolves #474
Tasks:
ChapterDetails
ComponentChapterDetails
ProjectDetails
Media