-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Google SafetyNey with Play Integrity #2371
Conversation
Thanks for opening the PR @EdilsonGalvao! @SirionRazzer would you mind reviewing it? Thank you very much! |
Document/0x05j-Testing-Resiliency-Against-Reverse-Engineering.md
Outdated
Show resolved
Hide resolved
Document/0x05j-Testing-Resiliency-Against-Reverse-Engineering.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made 2 suggestions which you can quickly 'accept' if you agree.
Hi @EdilsonGalvao! Thanks for the contribution! 🎉 I made two suggestions based on the usage of the word 'attest'. If you agree with them, please click the Merge buttons and then we can merge this PR! :) |
Hi @EdilsonGalvao , DISCLAIMER: If we agree on this, I would follow with accepting your current submission and creating a new PR with the suggested change: ... Integrated anti-fraud servicesAnti-fraud services like Google Play Integrity, Huawei SysIntegrity API, Talsec AppiCrypt, Copperhead, and GrapheneOS provide users and businesses with a range of options to protect against fraudulent activities in the digital space. The choice between these services is based on several factors, including the intended use case, operational area, data processing, legal aspects, and differentiating features. For example, Google Play Integrity is a popular choice for Android developers as it provides a comprehensive suite of services to detect and prevent fraudulent activity within Google Play Services-enabled devices. However, Google Play Integrity may not be usable with some enterprise devices, such as point-of-sale (POS) or kiosks that run on vanilla Android or in non-Google areas where Google services are unavailable. These services offer features like app and device tampering protection, API protection, license verification, or physical tampering protection, enabling businesses to validate the genuinity of devices, client apps, or API requests and verify that it has not been tampered with by a third party. It is essential to assess each service's strengths and weaknesses and consider the application's specific needs. Google Play Integrity[your current submission] References... |
Hello @SirionRazzer |
The current location isn't too important, since we are working on a major refactor of the entire guide and everything will be split up into different files. The intro is nice, but I don't think referencing commercial products is needed here or adds any value. The typical exceptions for adding commercial products are tools such as Ida Pro, Hopper, JEB, ... . In that same logic, why not add GuardSquare, zImperium, Promon, OneSpan, ..., which all provide some form of commercial RASP services with threat-signals for context based risk assessment, application-layer encrypted communication, etc? I can't immediately find any technical documents that explain how AppiCrypt is different from these other commercial products either. I'm also not that familiar with GrapheneOS and Copperhead, but we should at least refer to specific integrity solutions/features rather than just the name of the OS. |
Hello @TheDauntless |
@TheDauntless My main intention was to generalize this topic and highlight alternatives to Google Play Integrity. The original SafetyNet and the proposed Play Integrity update may mislead the reader to think these are the only option for the app to backend protection. The original article describes techniques used in RASP technology. Google Play Integrity/others are a step towards API protection and are better categorized as a WAAP technology. I think this guide shouldn't include Google Play Integrity without further explanation. Ultimately, there should be separate testing procedures regarding the WAAP technology (it's MASTG, after all). Still, Google Play Integrity demonstrates such technology and can be used as an implementation example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor style tweaks to remain consistent with other guides
Document/0x05j-Testing-Resiliency-Against-Reverse-Engineering.md
Outdated
Show resolved
Hide resolved
Document/0x05j-Testing-Resiliency-Against-Reverse-Engineering.md
Outdated
Show resolved
Hide resolved
Document/0x05j-Testing-Resiliency-Against-Reverse-Engineering.md
Outdated
Show resolved
Hide resolved
Document/0x05j-Testing-Resiliency-Against-Reverse-Engineering.md
Outdated
Show resolved
Hide resolved
Document/0x05j-Testing-Resiliency-Against-Reverse-Engineering.md
Outdated
Show resolved
Hide resolved
Document/0x05j-Testing-Resiliency-Against-Reverse-Engineering.md
Outdated
Show resolved
Hide resolved
Hi @EdilsonGalvao, there seems to be something wrong with the file now as it's being shown as if it were completely new, all lines have changed. Could you please take a look and verify that only your changes are being displayed in the diff? Thank you very much! |
864763b
to
45d0bc0
Compare
45d0bc0
to
e698102
Compare
…wasp-mastg into update-safetynet
* add masvs v1 IDs to tests table * Refactor column_titles and masvs_v1_id formatting in populate_dynamic_pages.py
…wasp-mastg into update-safetynet
…wasp-mastg into update-safetynet
…wasp-mastg into update-safetynet
Document/0x05j-Testing-Resiliency-Against-Reverse-Engineering.md
Outdated
Show resolved
Hide resolved
Document/0x05j-Testing-Resiliency-Against-Reverse-Engineering.md
Outdated
Show resolved
Hide resolved
Document/0x05j-Testing-Resiliency-Against-Reverse-Engineering.md
Outdated
Show resolved
Hide resolved
Document/0x05j-Testing-Resiliency-Against-Reverse-Engineering.md
Outdated
Show resolved
Hide resolved
Document/0x05j-Testing-Resiliency-Against-Reverse-Engineering.md
Outdated
Show resolved
Hide resolved
Document/0x05j-Testing-Resiliency-Against-Reverse-Engineering.md
Outdated
Show resolved
Hide resolved
Document/0x05j-Testing-Resiliency-Against-Reverse-Engineering.md
Outdated
Show resolved
Hide resolved
Document/0x05j-Testing-Resiliency-Against-Reverse-Engineering.md
Outdated
Show resolved
Hide resolved
Everything is good to go and all changes addressed
This PR updates SafetyNet content for Play Integrity.
Complete rewrite of the content highlighting the main points: summary, limitations, best practices and errors.
Update of references.
JSON example.
This PR closes #686.
owasp-masvs/issues/686