[MASWE-0020] Weak Encryption (by @appknox) #2910

sk3l10x1ng · 2024-10-10T12:29:04Z

sushi2k

Finished the weakness part. I applied my suggestions, let me know if anything to change from your end. Please look into the meta data of the weakness and clean it up accordingly.

Will look into the other parts in the upcoming days. Thanks for your contribution!

weaknesses/MASVS-CRYPTO/MASWE-0020.md

tests-beta/android/MASVS-CRYPTO/MASTG-TEST-0211.md

cpholguera · 2024-10-19T15:20:33Z

tests-beta/android/MASVS-CRYPTO/MASTG-TEST-0211.md

+
+## Overview
+
+In this test case, we will look for the use of weak encryption in Android applications. To do this, we need to focus on the cryptographic implementations of algorithm such as DES, 3DES,Weak encryption modes (e.g. ECB) and Cipher.getInstance("AES") defaults to ECB.


This needs to be more elaborate, similar to https://mas.owasp.org/MASTG/tests-beta/android/MASVS-CRYPTO/MASTG-TEST-0208/

Be careful with missing whitespace and ensure code elements are enclosed in backticks, e.g., Cipher

Also, try to use the refs we included in MASWE-0020 wherever possible as inline links for the text. Especially the ones from Support Google and Developer Android.

cpholguera · 2024-10-19T15:24:59Z

demos/android/MASVS-CRYPTO/MASTG_DEMO-0016/MASTG-DEMO-0016.md

@@ -0,0 +1,33 @@
+---
+platform: android
+title: Weak Encryption


To go inline with MAST-DEMO-0018

Suggested change

title: Weak Encryption

title: Uses of Insecure Encryption Algorithms in Cipher with semgrep

sk3l10x1ng · 2024-10-21T13:04:15Z

@cpholguera noted. will work on the requested changes

cpholguera · 2024-10-21T13:13:15Z

Thank you very much @sk3l10x1ng!

sk3l10x1ng · 2024-11-05T14:23:56Z

@cpholguera @sushi2k, requested changes have been done. thank you

cpholguera · 2024-11-29T08:38:57Z

tests-beta/android/MASVS-CRYPTO/MASTG-TEST-0211.md

@@ -0,0 +1,27 @@
+---
+title: Weak Encryption Algorithms


Please remove this file, we already have the one for algorithms: https://mas.owasp.org/MASTG/tests-beta/android/MASVS-CRYPTO/MASTG-TEST-0221/

@cpholguera does this file need to be completely removed or only remove the DES algorithm section?

This file can be completely removed. We already have this test in https://mas.owasp.org/MASTG/tests-beta/android/MASVS-CRYPTO/MASTG-TEST-0221/ including DES as well.

cpholguera · 2024-11-29T08:51:06Z

weaknesses/MASVS-CRYPTO/MASWE-0020.md

+- Always use modern, well-established cryptographic libraries in mobile apps that follow best practices and offer cryptographic algorithms that are aligned with the recommendations by NIST.
+- For example it is recommended to use secure modes of operations like GCM (Galois/Counter Mode) mode for AES with 256-bit keys, providing both encryption and authentication.


We can rework this section to mirror the previous one adding one mitigation for each of the modes of introduction.

Suggested change

- Always use modern, well-established cryptographic libraries in mobile apps that follow best practices and offer cryptographic algorithms that are aligned with the recommendations by NIST.

- For example it is recommended to use secure modes of operations like GCM (Galois/Counter Mode) mode for AES with 256-bit keys, providing both encryption and authentication.

- **Adopt Secure Algorithms**: Replace deprecated algorithms such as DES, 3DES, MD5, and SHA-1 with AES (minimum 256-bit key) and SHA-256 or higher.

- **Use Secure Encryption Modes**: Choose secure modes such as AES-GCM or AES-CCM and avoid insecure modes such as ECB.

- **Ensure Proper Initialization Vector Management**: Generate IVs using cryptographically secure random number generators and ensure they are unique for every operation.

- **Use Strong Key Sizes**: Enforce key lengths of at least 256 bits for AES and avoid using small or weak keys such as 56-bit DES keys.

- **Rely on Proper Cryptographic Libraries**: Avoid using XOR, Base64 encoding, or obfuscation as substitutes for encryption and rely on well-vetted cryptographic libraries.

cpholguera · 2024-11-29T09:54:44Z

demos/android/MASVS-CRYPTO/MASTG_DEMO-0016/MASTG-DEMO-0016.md

+
+### Evaluation
+
+Review each of the reported instances.


Suggested change

Review each of the reported instances.

The reported instances include:

cpholguera · 2024-11-29T09:55:09Z

demos/android/MASVS-CRYPTO/MASTG_DEMO-0016/MASTG-DEMO-0016.md

+- Line 37 seems the code utilize insecure DES algorithm.
+- Line 56 seems to utilize Cipher.getInstance("AES") defaults to ECB, which  is insecure.
+- Line 79 seems the code utilize insecure 3DES algorithm.


it's using it, right? It doesn't "seem" like it's using it.

cpholguera · 2024-11-29T09:57:03Z

demos/android/MASVS-CRYPTO/MASTG_DEMO-0016/MASTG-DEMO-0016.md

@@ -0,0 +1,33 @@
+---
+platform: android
+title: Uses of Insecure Encryption Algorithms in Cipher with semgrep


Please add another demo for title: Uses of Insecure Encryption Modes in Cipher with semgrep and test: MASTG-TEST-0231

@cpholguera

do we need to create new Demo file for title: Uses of Insecure Encryption Modes in Cipher with semgrep or make changes to the existing one.

The test:MASTG-TEST-0231 point to Reference to logging of APIs.

The ID of the "Weak Encryption Modes" has changed to MASTG-TEST-0232 https://mas.owasp.org/MASTG/tests-beta/android/MASVS-CRYPTO/MASTG-TEST-0232/

You may add a new demo pointing to that test or do it on a separate PR.

You can keep this demo with the changes indicated below.

rules/mastg-android-weak-encryption.yaml

cpholguera · 2024-12-06T07:49:04Z

@sk3l10x1ng any news on this? Thanks!

sk3l10x1ng · 2024-12-06T08:15:45Z

@cpholguera will work on the request changes

cpholguera · 2024-12-06T16:57:05Z

Thank you!

cpholguera · 2024-12-20T12:25:21Z

demos/android/MASVS-CRYPTO/MASTG_DEMO-0016/MASTG-DEMO-0016.md

+title: Uses of Insecure Encryption Algorithms in Cipher with semgrep
+id: MASTG-DEMO-0016
+code: [java]
+test: MASTG-TEST-0211


This can point to the existing test

Suggested change

test: MASTG-TEST-0211

test: MASTG-TEST-0221

cpholguera · 2024-12-20T12:27:53Z

demos/android/MASVS-CRYPTO/MASTG_DEMO-0016/MASTG-DEMO-0016.md

+
+### Observation
+
+The rule has identified five instances in the code file where an insecure encryption is used. The specified line numbers can be located in the original code for further investigation and remediation.


Suggested change

The rule has identified five instances in the code file where an insecure encryption is used. The specified line numbers can be located in the original code for further investigation and remediation.

The rule has identified five instances in the code file where insecure encryption algorithms are used.

cpholguera · 2025-01-15T11:08:53Z

@sk3l10x1ng we still have some requested changes here, do you have any news?

sk3l10x1ng · 2025-01-15T11:12:47Z

@sk3l10x1ng we still have some requested changes here, do you have any news?

I've completed the demo locally, I will push the commits to the pull request

sk3l10x1ng · 2025-01-16T16:05:54Z

@cpholguera I've added a new demo file. Please review it

cpholguera · 2025-01-16T18:17:04Z

Hi @sk3l10x1ng,

I still can see only one demo, unfortunately. Could you please double check?

The following demos (each in its own folder) are expected:

Uses of Insecure Encryption Algorithms in Cipher with semgrep
Uses of Insecure Encryption Modes in Cipher with semgrep

This would include 2 separate semgrep files.

sk3l10x1ng · 2025-01-17T11:55:11Z

Hi @sk3l10x1ng,

I still can see only one demo, unfortunately. Could you please double check?

The following demos (each in its own folder) are expected:

Uses of Insecure Encryption Algorithms in Cipher with semgrep

Uses of Insecure Encryption Modes in Cipher with semgrep

This would include 2 separate semgrep files.

@cpholguera updated the pull request with two demos

cpholguera · 2025-01-17T11:57:16Z

I can see them now, thank you!

cpholguera · 2025-01-17T12:01:12Z

weaknesses/MASVS-CRYPTO/MASWE-0020.md

+
+For example the use of TDEA (Triple Data Encryption Algorithm), which is often referred to as "Triple DES" or "3DES" is disallowed by NIST since end of 2023, due to known attacks like, "meet-in-the-middle", collision attacks and [Sweet32](https://nvd.nist.gov/vuln/detail/CVE-2016-2183).
+
+Similarly, hash functions such as MD5 and SHA-1, which were previously popular for ensuring data integrity, are now considered deprecated as attackers can generate hash collisions, potentially leading to data tampering.


cpholguera · 2025-01-17T12:01:56Z

weaknesses/MASVS-CRYPTO/MASWE-0020.md

+
+## Mode of Introduction
+
+- **Use of Deprecated Algorithms** : Relying on outdated or weak cryptographic algorithms can allow threat actors to attack the cipher text, key or exploit known vulnerabilities in the algorithm, for example through brute force attacks.


Suggested change

- **Use of Deprecated Algorithms** : Relying on outdated or weak cryptographic algorithms can allow threat actors to attack the cipher text, key or exploit known vulnerabilities in the algorithm, for example through brute force attacks.

- **Use of Deprecated Algorithms** : Relying on outdated or weak encryption algorithms can allow threat actors to attack the cipher text, key or exploit known vulnerabilities in the algorithm, for example through brute force attacks.

cpholguera · 2025-01-17T12:05:01Z

rules/mastg-android-weak-encryption.yaml

@@ -0,0 +1,12 @@
+rules:
+  - id: weak-encryption


Suggested change

- id: weak-encryption

- id: weak-encryption-algorithms

cpholguera · 2025-01-17T12:10:44Z

demos/android/MASVS-CRYPTO/MASTG-DEMO-0022/MastgTest.java

Rename to MastgTest_reversed.java (see other demos)

cpholguera · 2025-01-17T12:11:13Z

demos/android/MASVS-CRYPTO/MASTG_DEMO-0016/MastgTest.java

Rename to MastgTest_reversed.java (see other demos)

cpholguera · 2025-01-17T12:34:57Z

rules/mastg-android-weak-encryption-modes.yaml

+    languages:
+      - java
+    severity: WARNING
+    message: Weak encryption modes


Suggested change

message: Weak encryption modes

message: [MASVS-CRYPTO-1] Weak encryption modes found in use.

cpholguera · 2025-01-17T12:36:48Z

rules/mastg-android-weak-encryption-modes.yaml

+      - pattern: Cipher.getInstance("AES/ECB/ISO10126Padding")
+      - pattern: Cipher.getInstance("DES/ECB/PKCS5Padding")
+      - pattern: Cipher.getInstance("DESede/ECB/PKCS5Padding")
+    metadata:


Move before message

cpholguera · 2025-01-17T12:38:16Z

rules/mastg-android-weak-encryption-modes.yaml

+      - pattern: Cipher.getInstance("DES/ECB/PKCS5Padding")
+      - pattern: Cipher.getInstance("DESede/ECB/PKCS5Padding")
+    metadata:
+      summary: This rule looks for weak encryption mode like AES/ECB/NoPadding,


Update to be one line:

This rule looks for weak encryption modes such as AES-ECB.

cpholguera · 2025-01-17T12:41:30Z

demos/android/MASVS-CRYPTO/MASTG_DEMO-0016/run.sh

After all other changes were made. Rerun and push new outputs

cpholguera · 2025-01-17T12:42:07Z

demos/android/MASVS-CRYPTO/MASTG-DEMO-0022/run.sh

Update rule file name here as well.

After all other changes were made. Rerun and push new outputs

sk3l10x1ng added 5 commits October 1, 2024 20:30

added weaknesss

abb7d23

updated weakness

3ea5501

added MASTG-DEMO, rule, MASTG-TEST

8d02243

updated weakness.md

3df4c9e

fix spelling

d0c5955

sushi2k self-requested a review October 11, 2024 07:35

sushi2k requested changes Oct 18, 2024

View reviewed changes

sushi2k added 6 commits October 18, 2024 06:28

Update weaknesses/MASVS-CRYPTO/MASWE-0020.md

a6ef45b

Update weaknesses/MASVS-CRYPTO/MASWE-0020.md

54c1a9e

Update weaknesses/MASVS-CRYPTO/MASWE-0020.md

78777f8

Update weaknesses/MASVS-CRYPTO/MASWE-0020.md

057276f

Update weaknesses/MASVS-CRYPTO/MASWE-0020.md

8de7343

Update weaknesses/MASVS-CRYPTO/MASWE-0020.md

315fb5f

cpholguera assigned sk3l10x1ng Oct 18, 2024

cpholguera requested changes Oct 19, 2024

View reviewed changes

sk3l10x1ng added 7 commits October 22, 2024 11:07

removed duplicate

3416459

change status to new

62d06ff

updated title MASTG-TEST-0211.md

12bd55e

updated title MASTG-DEMO-0016.md

a47a60d

updated tests-beta

6580a35

fix lint

5c541a3

updated MASWE-0020.md

64bf491

cpholguera requested changes Nov 29, 2024

View reviewed changes

cpholguera added the changes-requested label Dec 6, 2024

updated mitigations

ebe5917

cpholguera reviewed Dec 20, 2024

View reviewed changes

sk3l10x1ng added 2 commits January 6, 2025 10:57

updated changes

461a389

removed MASTG-TEST-0211.md

004ada0

added new Demo

346edb0

sk3l10x1ng added 3 commits January 17, 2025 17:03

2 demo added

b5ab256

renamed semgrep files

0554d0e

updated

9447aec

cpholguera added changes-done and removed changes-requested labels Jan 17, 2025

sk3l10x1ng added 2 commits January 17, 2025 17:46

rename

371d8d1

updated

e09958f

cpholguera requested changes Jan 17, 2025

View reviewed changes

cpholguera added changes-requested and removed changes-done labels Jan 17, 2025


		## Overview

		In this test case, we will look for the use of weak encryption in Android applications. To do this, we need to focus on the cryptographic implementations of algorithm such as DES, 3DES,Weak encryption modes (e.g. ECB) and Cipher.getInstance("AES") defaults to ECB.

	title: Weak Encryption
	title: Uses of Insecure Encryption Algorithms in Cipher with semgrep

		- Always use modern, well-established cryptographic libraries in mobile apps that follow best practices and offer cryptographic algorithms that are aligned with the recommendations by NIST.
		- For example it is recommended to use secure modes of operations like GCM (Galois/Counter Mode) mode for AES with 256-bit keys, providing both encryption and authentication.

-- Always use modern, well-established cryptographic libraries in mobile apps that follow best practices and offer cryptographic algorithms that are aligned with the recommendations by NIST.
-- For example it is recommended to use secure modes of operations like GCM (Galois/Counter Mode) mode for AES with 256-bit keys, providing both encryption and authentication.
+- **Adopt Secure Algorithms**: Replace deprecated algorithms such as DES, 3DES, MD5, and SHA-1 with AES (minimum 256-bit key) and SHA-256 or higher.
+- **Use Secure Encryption Modes**: Choose secure modes such as AES-GCM or AES-CCM and avoid insecure modes such as ECB.
+- **Ensure Proper Initialization Vector Management**: Generate IVs using cryptographically secure random number generators and ensure they are unique for every operation.
+- **Use Strong Key Sizes**: Enforce key lengths of at least 256 bits for AES and avoid using small or weak keys such as 56-bit DES keys.
+- **Rely on Proper Cryptographic Libraries**: Avoid using XOR, Base64 encoding, or obfuscation as substitutes for encryption and rely on well-vetted cryptographic libraries.

	Review each of the reported instances.
	The reported instances include:


		### Observation

		The rule has identified five instances in the code file where an insecure encryption is used. The specified line numbers can be located in the original code for further investigation and remediation.


		For example the use of TDEA (Triple Data Encryption Algorithm), which is often referred to as "Triple DES" or "3DES" is disallowed by NIST since end of 2023, due to known attacks like, "meet-in-the-middle", collision attacks and [Sweet32](https://nvd.nist.gov/vuln/detail/CVE-2016-2183).

		Similarly, hash functions such as MD5 and SHA-1, which were previously popular for ensuring data integrity, are now considered deprecated as attackers can generate hash collisions, potentially leading to data tampering.


		## Mode of Introduction

		- Use of Deprecated Algorithms : Relying on outdated or weak cryptographic algorithms can allow threat actors to attack the cipher text, key or exploit known vulnerabilities in the algorithm, for example through brute force attacks.

	message: Weak encryption modes
	message: [MASVS-CRYPTO-1] Weak encryption modes found in use.

[MASWE-0020] Weak Encryption (by @appknox) #2910

Are you sure you want to change the base?

[MASWE-0020] Weak Encryption (by @appknox) #2910

Conversation

sk3l10x1ng commented Oct 10, 2024

sushi2k left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cpholguera Oct 19, 2024 • edited by sushi2k Loading

Choose a reason for hiding this comment

sk3l10x1ng commented Oct 21, 2024 • edited Loading

cpholguera commented Oct 21, 2024

sk3l10x1ng commented Nov 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cpholguera Nov 29, 2024 • edited Loading

Choose a reason for hiding this comment

sk3l10x1ng Dec 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cpholguera commented Dec 6, 2024

sk3l10x1ng commented Dec 6, 2024

cpholguera commented Dec 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cpholguera commented Jan 15, 2025

sk3l10x1ng commented Jan 15, 2025

sk3l10x1ng commented Jan 16, 2025

cpholguera commented Jan 16, 2025

sk3l10x1ng commented Jan 17, 2025 • edited Loading

cpholguera commented Jan 17, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cpholguera Oct 19, 2024 •

edited by sushi2k

Loading

sk3l10x1ng commented Oct 21, 2024 •

edited

Loading

sk3l10x1ng commented Nov 5, 2024 •

edited

Loading

cpholguera Nov 29, 2024 •

edited

Loading

sk3l10x1ng Dec 19, 2024 •

edited

Loading

sk3l10x1ng commented Jan 17, 2025 •

edited

Loading