Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature multi presentation #29

Merged

Conversation

moratori
Copy link
Member

@moratori moratori commented Sep 27, 2024

Summary

The core implementation of sending multiple VP tokens was completed from the beginning, so this PR included minor modifications to it.

Changed

The following modifications were made to allow multiple VCs to VP at the same time

  • Added test when the number of elements in the credential array of the first argument of respondVPResponse is 2 or more.
  • Modified SharingRequestModel to allow it to hold multiple SubmissionCredentials.

Also refactored related functionality.

  • Removed unnecessary properties of SharingRequestModel, submissionClaims.
  • Removed unused data type CredentialSharingModel.
  • Fixed improper naming of VP token creation function and confusing return value.

Updated library to 3.2.2 to resolve Web3swift compile failures in Xcode 16.

Copy link
Collaborator

@ryosuke-wakaba ryosuke-wakaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryosuke-wakaba ryosuke-wakaba merged commit 0b6f704 into OWND-Project:develop Oct 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants