fix #196
Open
fix #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adamskrodzki
commented
May 10, 2023
adamskrodzki
commented
- sanity checks added in contract constructors
- using existing serviceRegistry rather than redeploying
- delay set to 0 also on mainnet
halaprix
requested changes
May 11, 2023
| console.log('address 0x0 deploying ', serviceName) | ||
| return (await utils.deployContract(ethers.getContractFactory(contractName), params)) as T | ||
| } else { | ||
| console.log('"address not 0x0 fetching instead ', serviceName) |
There was a problem hiding this comment.
maybe this?
Suggested change
| console.log('"address not 0x0 fetching instead ', serviceName) | |
| console.log('service address not 0x0 - fetching from Service Registry ', serviceName) |
| const address = await serviceRegistry.getRegisteredService(serviceName) | ||
|
|
||
| if (address === constants.AddressZero) { | ||
| console.log('address 0x0 deploying ', serviceName) |
There was a problem hiding this comment.
maybe
Suggested change
| console.log('address 0x0 deploying ', serviceName) | |
| console.log('service address 0x0 - deploying ', serviceName) |
| @@ -67,6 +68,9 @@ const createServiceRegistry = (utils: HardhatUtils, serviceRegistry: ServiceRegi | |||
| const existingAddress = await serviceRegistry.getServiceAddress(hash) | |||
| const gasSettings = await utils.getGasSettings() | |||
| if (existingAddress === constants.AddressZero) { | |||
| // console.log( | |||
| const ServiceRegistryInstance = | ||
| utils.hre.network.name === Network.HARDHAT | ||
| ? ((await utils.deployContract(ethers.getContractFactory('ServiceRegistry'), [0])) as ServiceRegistry) | ||
| : await ethers.getContractAt('ServiceRegistry', '0x5e81a7515f956ab642eb698821a449fe8fe7498e', signer) |
| ) | ||
| const signer = | ||
| utils.hre.network.name === Network.LOCAL | ||
| ? await ethers.getImpersonatedSigner('0x0B5a3C04D1199283938fbe887A2C82C808aa89Fb') |
There was a problem hiding this comment.
move to addresses.ts or get with owner() directly from SR
| await ensureServiceRegistryEntry(getExecuteAdapterNameHash(address), adapter) | ||
| } | ||
| } | ||
|
|
||
| /* | ||
| if (system.closeCommand && system.closeCommand.address !== constants.AddressZero) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.