-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an improved, experimental Pathfinder 2e Bestiary layout #11
Add an improved, experimental Pathfinder 2e Bestiary layout #11
Conversation
This is named differently as an "Experimental" layout while I work on having this be included and output from other tools. Later, I plan to change this to the default layout and rename the other one to the Legacy layout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @mProjectsCode, no problems with the esbuild changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create named variables for the command line arguments at the top of the file and provide some documentation for the arguments. All in an effort to improve readability and maintainability.
done. also fixed the watch functionality and restructured it a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to use a proper argument parser with dashes and so on where the order of arguments does not matter, but I can do that, no need for you to do that in this PR.
This layout is intended to functionally appear mostly the same to the default Pathfinder 2e creature layout. The difference is primarily in the YAML required to create the layout. The intention is for this to eventually become the new default layout - see Fantasy Statblocks#436 for the overall plan.
There are a lot of differences, but the primary goal here was to make it less of a pain to manually write and edit these statblocks, and to allow plugins and scripts to access the data in reasonable ways. I've done this by:
In particular:
There's also a few quality-of-life improvements:
Abilities have been left pretty much untouched.
I'm open to feedback here if folks have other improvements that I haven't covered here.
Here's an example statblock with placeholder values using this layout:
I've spot-checked this with statblocks generated with a local version of ttrpg-convert-cli that has Pf2e Fantasy Statblocks support.
Just for good measure, here's a statblock for an Adult Brine Dragon so you can see what it looks like with real data:
Here's what it looks like rendered: