Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate addon to kodi19 / python3 #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

makepanic
Copy link

fixes #13

@makepanic
Copy link
Author

makepanic commented Aug 10, 2021

Hi thanks for maintaining this great addon. I noted that it didn't work after upgrading to kodi@19.

After some print() debugging i was able to seemingly fix all the issues and it's now streaming from somafm again:

20210810-210340

I bumped the version to 2.0.0 as it's a breaking change due to requiring kodi@19. I'm not sure what's the usual approach is to move it to a new major kodi version.

@evinr
Copy link
Collaborator

evinr commented Nov 15, 2021

Any idea when this will be accepted? Or will there be plans to release a v19/Python 3 friendly version?

@RacerXnyc
Copy link

I also would love to have this working with Kodi 19

@inverse
Copy link
Collaborator

inverse commented Nov 16, 2021

@evinr @RacerXnyc we need someone or a group of people to maintain this add-on. In the linked ticket it outlines this :)

@inverse
Copy link
Collaborator

inverse commented Nov 16, 2021

@Oderik any chance you could merge this one to get compatibility back... Or is the process more manual steps than just that?

@evinr
Copy link
Collaborator

evinr commented Nov 16, 2021

@inverse Thanks for the explanation! How is the new maintainer decided?

I just ran kodi-addon-checker and got a few errors related to the old language directory structure. I will respond in the other thread if I get this passing and working.

Once it is passing kodi-addon-checker then whoever owns the repo/project will need to submit a PR as a single commit. Or at least that is what I can surmise. https://github.com/xbmc/repo-plugins/tree/matrix

@Oderik
Copy link
Owner

Oderik commented Nov 16, 2021

Hi @evinr, @inverse, @RacerXnyc and @makepanic,

thanks for your interest in this addon. Please have a look at this post of mine (inverse already mentioned it I think): #13 (comment)

To sum it up: I need someone to take over maintenance of this project. And that person or group should also find out how to propagate an official add on update (it seems to me that evinr did that) and what works best regarding hand over of this repo.

So of course I could just merge the PR (untested), but then the project would remain unmaintained again. ;) So, it seems to me that one or some or all of you might be a good option for the future maintainers of this. What do you think? :D

Please discuss and tell me how to transfer ownership of the repo. Again, please note the thoughts in the linked comments.

@RacerXnyc
Copy link

RacerXnyc commented Nov 16, 2021

@inverse, @Oderik (and everyone),

Yes, I saw that they need someone to maintain it. Unfortunately that's not me. I'm not a coder or programmer and don't understand 'any of this stuff'. I don't really even completely understand how to use github. I get what it's for, of course, and understand some of the lingo, but I struggle with large sections of it.

The Soma addon was the final, only addon remaining from my 18 build that isn't 19 compatible. I wrote the soma guys and they sent me here. I saw @evinr's comment and wanted to chime in myself.

Full emotional support! No technical skills. :(

I can contribute, however, with writing- instructions, descriptions, etc.. Assuming I understand the thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Currently the app is not compatible with Kodi 19
5 participants