v4 URL Mode #2919
Merged
v4 URL Mode #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinite-persistence
force-pushed
the
v4.url.mode
branch
from
602f1c2
to
3178c4c
Compare
Didn't remove them previously to make the diffs clearer + quick reference
Previously used in `publish-error.js`, but that has been removed.
It used to be a common task between v1 and v2/v3/v4, so it was placed at the top. But since we are moving to a v4-only solution, it's much clearer to move it as a sequential task.
infinite-persistence
force-pushed
the
v4.url.mode
branch
from
3178c4c
to
edff677
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
## Issue When publishing with preview=on, the name collision warning briefly appears https://user-images.githubusercontent.com/34790748/260001187-84c5f604-ee2f-4757-88d6-412a5569279c.webm ## Why When a publish is pending via tus, we prevent the next upload form from re-using any of the pending claim names. As we are replacing v1 with v4, every upload (including previews), is a tus upload now, so it's trying to warning against itself, lol. ## Fix Just don't include previews in the pending name list.
|
|
This reverts commit a9f7cbd.
infinite-persistence
added a commit
that referenced
this pull request
Aug 14, 2023
Reverts 3b442bc The TUS address returned is incorrect.
infinite-persistence
added a commit
that referenced
this pull request
Aug 14, 2023
The backend issue has been resolved. Also bumped the minimum version for better logging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before-merge checklist
PR Details
Issues
204_pendingindefinitely.nameclash in quick succession?(the preview quest should have
preview: truein the SDK params).https://api.na-backend.dev.odysee.com/api/v1/asynqueries/05adfe468d0479edcda2000737974781stream_updateon v4?file_path.stream_updateand nofile_path, but I got astatus_500.