Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve collection edit performance #3185

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Improve collection edit performance #3185

merged 2 commits into from
Nov 21, 2024

Conversation

keikari
Copy link
Contributor

@keikari keikari commented Nov 20, 2024

No description provided.

@keikari keikari changed the title Collection edit: Fetch collection items only if not fetched before Improve collection edit perfomance Nov 21, 2024
@keikari keikari changed the title Improve collection edit perfomance Improve collection edit performance Nov 21, 2024
@tzarebczan tzarebczan merged commit cfdca7a into master Nov 21, 2024
2 checks passed
@tzarebczan tzarebczan deleted the fix-playlist-lag2 branch November 21, 2024 12:41
@tzarebczan
Copy link
Contributor

Awesome, thank you! Saw the discussion in the issue as well.

@infinite-persistence
Copy link
Collaborator

Just a quick check, Miko:
the previous code performs the deletion for both QUEUE_EDIT and COLLECTION_EDIT, but now it's only for the latter. Does it need to happen for both? (not familiar with the purpose of these 2 lists).

@keikari
Copy link
Contributor Author

keikari commented Nov 21, 2024

Didn't thought about that, but should still be fine.

updated seems to be used to keep track of the last edited timestamp in cases where one decides to clear edits instead of publishing them.

unsavedChanges is used so that changing the sorting of the list won't become permanent until user saves the changes. It's only used in the "Arrange"-mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants