Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DryRun the comment creation before submitting the tip #3214

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

keikari
Copy link
Contributor

@keikari keikari commented Jan 24, 2025

Handles the multiple channels error, and should also handle other possible comment creation errors caused by front end.

@tzarebczan tzarebczan merged commit 534d9c5 into master Jan 24, 2025
2 checks passed
@tzarebczan tzarebczan deleted the comment-dry-run branch January 24, 2025 15:05
keikari added a commit that referenced this pull request Jan 26, 2025
* DryRun the comment creation before submitting the tip (#3214)

* DryRun comment creation before submitting the tip

* Include commentron to the dryRun

* Remove lint change

---------

Co-authored-by: miko <[email protected]>

* Add "amount" for LBC tips in comment create

* Fix dryRun hyperchat issue

* Fix Send-button flicker

* Minor adjustment

---------

Co-authored-by: miko <[email protected]>
keikari added a commit that referenced this pull request Jan 27, 2025
* DryRun comment creation before submitting the tip

* Include commentron to the dryRun

* Remove lint change

---------

Co-authored-by: miko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants