Only reset player recoveryAttempts if video really started to play #3218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed infinite looping with retry attempts on this video.
(User didn't mentioned about looping, just about the crashing itself. Saw it here in FF/Brave, so maybe device specific?)
EDIT: Looping seems to not happen if auto play is disabled in browser
Now it would only reset the attempts if the current time actually changes when the video is "playing".
The reset that happened on "play" also caused looping.
Currently happens when skipping to around 30mins in this video. Think the upload is corrupted in the middle.
https://odysee.com/@%D9%85%D8%B1%D9%83%D8%B2_%D8%A7%D9%84%D8%B2%D9%87%D8%B1%D8%A7%D8%A1_%D8%B9%D9%84%D9%8A%D9%87%D8%A7_%D8%A7%D9%84%D8%B3%D9%84%D8%A7%D9%85:3/2025-01-22-%D8%B3%D9%88%D8%B1%D8%A9-%D8%A7%D9%84%D9%83%D9%87%D9%81-%D8%A7%D9%84%D8%B1%D8%AC%D8%A7%D9%84-%D8%A7%D9%84%D9%81%D8%A7%D8%A6%D8%B2%D9%88%D9%86:7