WIP - linearly increase mini stake size #497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzeoneth
reviewed
Nov 30, 2023
| uint8 _numBigStepLevel | ||
| uint8 _numBigStepLevel, | ||
| uint256 _initialStakeAmount, | ||
| uint256 _stakeAmountSlope | ||
| ) public initializer { |
There was a problem hiding this comment.
not directly related to this pr but since the challenge manager should be immutable we can remove the initializer and use a constructor so that a brunch of these config can be made immutable to save gas
There was a problem hiding this comment.
ok i can make that pr
contracts/src/challengeV2/libraries/EdgeChallengeManagerLib.sol
Outdated
Show resolved
Hide resolved
…hainLabs/bold into linear-increase-mini-stakes
…hainLabs/bold into linear-increase-mini-stakes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API likely to slightly change due to different mini stake function.
uint256 ChallengeEdge::stakeAmountcould be made smaller to share a slot with other variableswould a new
EdgeChallengeManager::isDefeated(bytes32 edgeId)be helpful?