-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NIT-2489] Honest Strategy Revamp to Consider Path Weights #634
Conversation
4bb65bd
to
1cfe2fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the description of the PR, Raul suggests that we should also be checking in the e2e_test.go that the essential root edges are confirmed in addition to winning the challenge, can you take a stab at that as well?
Mostly, this PR is looking really good though. I especially like the simplification of getting rid of the min heap.
Note @eljobe , the big diff is due to updating MODULE.bazel.lock. The real diff is still around +1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
With the current timings, it usually takes a little bit to long to fit in the "medium" size category.
Fixes: NIT-2489
Key reading:
Background:
This PR changes the honest strategy to match the expected specification linked above. The core idea is that edge trackers should only attempt to bisect or open subchallenges if the weight of timers to their closest root ancestor is < 1 challenge period.
This means we also need to change the rules for when an edge tracker should "despawn". The changes are as follows:
Terminology remapping:
This PR also adds an e2e test that checks that all essential root edges are confirmed, beyond just the challenge completing.