-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bold #193
Merged
Merged
feat: bold #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lee Bousfield <[email protected]> Co-authored-by: Chris Buckland <[email protected]> Co-authored-by: shotaro <[email protected]> Co-authored-by: Henry <[email protected]>
This reverts commit 8269b1a.
Co-authored-by: Chris Buckland <[email protected]> Co-authored-by: Henry <[email protected]>
* refactor: bold interfaces * 3.0.0-alpha.1 * fix: missing interface methods * fix: use interface when possible * fix: format * 3.0.0-alpha.2 * chore: update slither db * fix: allowlist npm audit issue
* chore: use 2.1.0 for OldRollup * fix: wait for deployment * feat: allow excessStakeReceiver to be eoa * wip: print action calldata * wip: show executor perform call data * fix: testnode master rollup addr * wip: add local testnode executor * wip: testnode validator * wip: testnode validator wallet * fix: small range lookup * chore: sample env for testnode * feat: bold upgrade execute and improved logging * fix: use nextInboxPosition at upgrade to verify * Revert "fix: use nextInboxPosition at upgrade to verify" This reverts commit 6948823. * fix: getlog range * fix: nextInboxPosition * chore: print bold addresses * chore: log more stuffs * chore: use 1000 range when searching log * fix: parse event to get nextInboxPosition and more logging * feat: allow ROLLUP_ADDRESS override in bold upgrade * chore: whitelist npm audit issue * chore: remove excessStakeReceiver check * chore: revert typo
* chore: use 2.1.0 for OldRollup * fix: wait for deployment * feat: allow excessStakeReceiver to be eoa * wip: print action calldata * wip: show executor perform call data * fix: testnode master rollup addr * wip: add local testnode executor * wip: testnode validator * wip: testnode validator wallet * fix: small range lookup * chore: sample env for testnode * feat: bold upgrade execute and improved logging * fix: use nextInboxPosition at upgrade to verify * Revert "fix: use nextInboxPosition at upgrade to verify" This reverts commit 6948823. * fix: getlog range * fix: nextInboxPosition * chore: print bold addresses * chore: log more stuffs * chore: use 1000 range when searching log * fix: parse event to get nextInboxPosition and more logging * feat: allow ROLLUP_ADDRESS override in bold upgrade * refactor: remove rollup reader * format: fix * refactor: do not upgrade old rollup * fix: format again * fix: typo * fix: min version required * chore: warn if old rollup is old * feat: make bold rollup address predictable easily * fix: expectedRollupAddress * feat: isRollupDeployedAtAddress * feat: validateRollupDeployedAtAddress * fix: squeeze within size limit * chore: whitelist npm audit issue * chore: remove excessStakeReceiver check * chore: revert typo
* chore: testnode for bold upgrade * test: stakeToken should be contract
* create failing test for rollup creator * annotate * fix rollup creator failure * move test token * test outbox execution with zero value * rule out a zero transfer * rule out rollup zero transfers * rule out FactoryDeployerHelper * test: createRetryableTicket with NoZeroTransferToken --------- Co-authored-by: gzeon <[email protected]>
Co-authored-by: gzeon <[email protected]>
* chore: effectively disableing delay buffer * chore: typo Co-authored-by: Henry <[email protected]> --------- Co-authored-by: Henry <[email protected]>
* refactor: move hardcoded value to config * refactor: minimumAssertionPeriod and validatorAfkBlocks in bold upgrade setting * perf: remove onchain verification * chore: update sigs * refactor: remove hardcode in rollup initialize * chore: update example * test: new config param * fix: format test * test: fix config * Apply suggestions from code review Co-authored-by: Henry <[email protected]> --------- Co-authored-by: Henry <[email protected]>
* docs: add note regarding reorg * wip: use create2 * edit comment * start over * use create2 in bridge creator * require rollup exists * fix tests * fix lint * Revert "docs: add note regarding reorg" This reverts commit d451b72. * remove unnecessary args from salt * fmt * put the salt args back * refactor: move hardcoded value to config * refactor: minimumAssertionPeriod and validatorAfkBlocks in bold upgrade setting * perf: remove onchain verification * chore: update sigs * refactor: remove hardcode in rollup initialize * chore: update example * test: new config param * fix: format * fix: BridgeTemplates * fix: memory * fix: format test * feat: use msg.data hash as salt * test: fix * test: fix config * fix: slither * refactor: bridge creator create2Salt * chore: remove unintended change * chore: slither --------- Co-authored-by: gzeon <[email protected]> Co-authored-by: gzeon <[email protected]>
godzillaba
previously approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
* update links in README.md * update link in README.md update link to deployed nitro contract addresses * adding #core-contracts to end of link text --------- Co-authored-by: gzeon <[email protected]>
fix: merge doc fixes into main
yahgwai
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merging OffchainLabs/bold@6b42a38f /contracts into
nitro-contracts
contracts should be identical to the https://github.com/OffchainLabs/bold except some mocks, precompiles interface, and some renamed variables in BOLDUpgradeAction
e2e test is currently disabled due to lack of nitro support
resolves BLK-176