refactor: move hardcoded value to config #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzeoneth
commented
Dec 2, 2024
| require(_delaySeconds == delaySeconds, "DelayBuffer: delaySeconds"); | ||
| require(_futureBlocks == futureBlocks, "DelayBuffer: futureBlocks"); | ||
| require(_futureSeconds == futureSeconds, "DelayBuffer: futureSeconds"); | ||
|
|
There was a problem hiding this comment.
have to remove these checks for contract code size, I don't think there are too much risk but arguable
godzillaba
approved these changes
Dec 9, 2024
Co-authored-by: Henry <[email protected]>
yahgwai
approved these changes
Dec 10, 2024
| @@ -433,17 +442,6 @@ contract BOLDUpgradeAction { | |||
| PROXY_ADMIN_SEQUENCER_INBOX.upgrade(sequencerInbox, IMPL_SEQUENCER_INBOX); | |||
| } | |||
|
|
|||
| // verify | |||
There was a problem hiding this comment.
Is there manual checklist somewhere that we could add these to?
There was a problem hiding this comment.
not yet but we can make something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the 4bytes of
RollupCreator.createRollupandRollupAdminLogic.initializewill be changed, won't be an issue if we have the change with the v3 release because they was already different from v2.