parent and child insurance stubs #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srya-b
reviewed
Dec 4, 2024
There was a problem hiding this comment.
is the assumption that the signedCommitment in buy also encodes the values being committed to alongside the commitment + signature?
There was a problem hiding this comment.
yeah, just pushed up a commit that includes those. the entire struct SequencerCommitment is signed over
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| address public immutable childChainContract; | ||
|
|
||
| // D | ||
| uint256 public depositedAmount; |
Check failure
Code scanning / Slither
Uninitialized state variables High
Comment on lines
+73
to
+125
| function buy( | ||
| uint256 minSatisfied, | ||
| SequencerCommitment calldata commitment, | ||
| bytes calldata signature, | ||
| RetryableParams calldata retryableParams | ||
| ) public payable { | ||
| // require depositAmount - insuranceSold + minSatisfied >= insuranceAmount | ||
| // put this check first because it's the mosy likely to fail without user error | ||
| require(depositedAmount - insuranceSold + minSatisfied >= commitment.insuranceAmount, "potential undercollateralization"); | ||
|
|
||
| // verify the signature | ||
| require(isValidSignature(commitment, signature), "invalid signature"); | ||
|
|
||
| // require msg.value == insuranceCost + retryableCost | ||
| uint256 retryableCost = retryableParams.maxSubmissionCost + retryableParams.gasLimit * retryableParams.gasPrice; | ||
| require(msg.value == retryableCost + commitment.insuranceCost, "invalid value"); | ||
|
|
||
| // require !hasUsedCommitment(commitment) | ||
| require(!hasUsedCommitment(commitment), "commitment already used"); | ||
|
|
||
| // increment insuranceSold by amount | ||
| insuranceSold += commitment.insuranceAmount; | ||
|
|
||
| // mark commitment as used | ||
| usedCommitments[hashCommitment(commitment)] = true; | ||
|
|
||
| // build calldata for child contract | ||
| bytes memory data = abi.encodeCall( | ||
| Child.commit, | ||
| ( | ||
| sequenceNumber, | ||
| commitment.beneficiary, | ||
| commitment.insuranceAmount, | ||
| commitment.blockNum, | ||
| commitment.blockHash | ||
| ) | ||
| ); | ||
|
|
||
| // create a retryable to hit the child contract settle function, sending msg.value | ||
| inbox.createRetryableTicket{value: msg.value}({ | ||
| to: childChainContract, | ||
| l2CallValue: commitment.insuranceCost, | ||
| maxSubmissionCost: retryableParams.maxSubmissionCost, | ||
| excessFeeRefundAddress: msg.sender, | ||
| callValueRefundAddress: msg.sender, | ||
| gasLimit: retryableParams.gasLimit, | ||
| maxFeePerGas: retryableParams.gasPrice, | ||
| data: data | ||
| }); | ||
|
|
||
| // increment seqNum | ||
| sequenceNumber++; | ||
| } |
Check failure
Code scanning / Slither
Reentrancy vulnerabilities High
Comment on lines
+73
to
+125
| function buy( | ||
| uint256 minSatisfied, | ||
| SequencerCommitment calldata commitment, | ||
| bytes calldata signature, | ||
| RetryableParams calldata retryableParams | ||
| ) public payable { | ||
| // require depositAmount - insuranceSold + minSatisfied >= insuranceAmount | ||
| // put this check first because it's the mosy likely to fail without user error | ||
| require(depositedAmount - insuranceSold + minSatisfied >= commitment.insuranceAmount, "potential undercollateralization"); | ||
|
|
||
| // verify the signature | ||
| require(isValidSignature(commitment, signature), "invalid signature"); | ||
|
|
||
| // require msg.value == insuranceCost + retryableCost | ||
| uint256 retryableCost = retryableParams.maxSubmissionCost + retryableParams.gasLimit * retryableParams.gasPrice; | ||
| require(msg.value == retryableCost + commitment.insuranceCost, "invalid value"); | ||
|
|
||
| // require !hasUsedCommitment(commitment) | ||
| require(!hasUsedCommitment(commitment), "commitment already used"); | ||
|
|
||
| // increment insuranceSold by amount | ||
| insuranceSold += commitment.insuranceAmount; | ||
|
|
||
| // mark commitment as used | ||
| usedCommitments[hashCommitment(commitment)] = true; | ||
|
|
||
| // build calldata for child contract | ||
| bytes memory data = abi.encodeCall( | ||
| Child.commit, | ||
| ( | ||
| sequenceNumber, | ||
| commitment.beneficiary, | ||
| commitment.insuranceAmount, | ||
| commitment.blockNum, | ||
| commitment.blockHash | ||
| ) | ||
| ); | ||
|
|
||
| // create a retryable to hit the child contract settle function, sending msg.value | ||
| inbox.createRetryableTicket{value: msg.value}({ | ||
| to: childChainContract, | ||
| l2CallValue: commitment.insuranceCost, | ||
| maxSubmissionCost: retryableParams.maxSubmissionCost, | ||
| excessFeeRefundAddress: msg.sender, | ||
| callValueRefundAddress: msg.sender, | ||
| gasLimit: retryableParams.gasLimit, | ||
| maxFeePerGas: retryableParams.gasPrice, | ||
| data: data | ||
| }); | ||
|
|
||
| // increment seqNum | ||
| sequenceNumber++; | ||
| } |
Check warning
Code scanning / Slither
Unused return Medium
srya-b
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.