Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update links in README.md #276

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Conversation

0xallan
Copy link
Contributor

@0xallan 0xallan commented Dec 10, 2024

Link to nitro contract addresses was broken (https://developer.arbitrum.io/useful-addresses)

Separate link to token bridge contract addresses could be replaced with the same updated docs link (https://docs.arbitrum.io/for-devs/dev-tools-and-resources/chain-info)

Copy link

cla-bot bot commented Dec 10, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@CLAassistant
Copy link

CLAassistant commented Dec 10, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ 0xallan
❌ gzeoneth
You have signed the CLA already but the status is still pending? Let us recheck it.

@hkalodner
Copy link
Collaborator

@cla-bot check

@cla-bot cla-bot bot added the s label Dec 10, 2024
Copy link

cla-bot bot commented Dec 10, 2024

The cla-bot has been summoned, and re-checked this pull request!

README.md Show resolved Hide resolved
joshuacolvin0
joshuacolvin0 previously approved these changes Dec 10, 2024
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xallan 0xallan changed the base branch from main to develop December 10, 2024 21:46
@0xallan 0xallan dismissed joshuacolvin0’s stale review December 10, 2024 21:46

The base branch was changed.

@gzeoneth gzeoneth changed the base branch from develop to bold-merge December 11, 2024 06:02
@gzeoneth gzeoneth merged commit fd714e3 into OffchainLabs:bold-merge Dec 11, 2024
6 of 13 checks passed
gzeoneth added a commit that referenced this pull request Dec 11, 2024
* update links in README.md

* update link in README.md

update link to deployed nitro contract addresses

* adding #core-contracts to end of link text

---------

Co-authored-by: gzeon <[email protected]>
gzeoneth added a commit that referenced this pull request Dec 11, 2024
* update links in README.md (#276)

* update links in README.md

* update link in README.md

update link to deployed nitro contract addresses

* adding #core-contracts to end of link text

---------

Co-authored-by: gzeon <[email protected]>

* fix: new foundry storage format

* fix: CacheManager storage

---------

Co-authored-by: Allan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants