Add a test for storage trie determinism #2914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a new BigMap contract in the nitro-contracts repo in the mocks package. The test attempts to set a lot of storage slots to some value in one transaction, and then to clear 75% of them and add 10% more values in a second transaction. Finally, validation is run to ensure that the validator is behaving correctly. The idea is that this test will pass validation with the state db's deterministic flag set, but fail without it set. Related to: NIT-3068
This is just to make sure that the test is implemented as it was specified in the issue.
The previous bigmap branch was based off of main instead of pre-bold. This should make it so that the bigmap is the only contract that has been added since the pre-bold pin. Related to NIT-3068
By removing one of the two methods on the contract, it simplifies the code, but makes for a slight bump in the gas needed. Part of: NIT-3068
PlasmaPower
suggested changes
Feb 3, 2025
This is what CI is configured to check.
According to Harry Ng in Slack, v2-main is the new pre-bold
eljobe
added a commit
that referenced
this pull request
Feb 10, 2025
This will immediately start failing once it's merged in, but, then we should be able to merge in #2914 which (in addition to adding the test, also sets the pin for the contracts submodule to v2-main.)
Tristan-Wilson
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a new BigMap contract in the nitro-contracts repo in the mocks package.
The test attempts to set a lot of storage slots to some value in one transaction, and then to clear 75% of them and add 10% more values in a second transaction.
Finally, validation is run to ensure that the validator is behaving correctly.
The idea is that this test will pass validation with the state db's deterministic flag set, but fail without it set.
Related to: NIT-3068