Allow BlockMetadata to be generated when timeboost isn't enabled #2932
Conversation
ganeshvanahalli
requested review from
tsahee,
Tristan-Wilson and
joshuacolvin0
There was a problem hiding this comment.
I see how this allows the block metadata to be recorded even when Timeboost is disabled. But, is there some other check somewhere that we are >= some target block number before we start collecting block metadata? We don't want to just unconditionally collect the block metadata, right?
timeboost/redis_coordinator.go
Outdated
| @@ -92,7 +92,7 @@ func (rc *RedisCoordinator) GetAcceptedTxs(round, startSeqNum, endSeqNum uint64) | |||
| fetchMsg := func(key string) *ExpressLaneSubmission { | |||
| msgBytes, err := rc.client.Get(ctx, key).Bytes() | |||
| if err != nil { | |||
| log.Error("Error fetching accepted expressLane tx", "key", key, "err", err) | |||
| log.Debug("Error fetching accepted expressLane tx", "key", key, "err", err) | |||
There was a problem hiding this comment.
Is this really an expected error that we want to just quietly ignore?
There was a problem hiding this comment.
yep its an expected error, since we have deterministic search of pending keys instead of redis.Scan
There was a problem hiding this comment.
We should log an error or warning normally but ignore it if it's redis.Nil
This is handled using TrackBlockMetadataFrom flag of transaction streamer nitro/arbnode/transaction_streamer.go Line 78 in b3022c6 |
ganeshvanahalli
dismissed stale reviews from Tristan-Wilson and eljobe
via
ec4b665
No description provided.