Fix auction resolution during a tie #2971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tristan-Wilson
previously approved these changes
Feb 21, 2025
system_tests/timeboost_test.go
Outdated
|
|
||
| } | ||
|
|
||
| var expectedWinner common.Address |
There was a problem hiding this comment.
Does the bidHash change between runs of the test so that both alice and bob being the expected winner are tested? Could we run this test a few times then?
There was a problem hiding this comment.
Since hashing is pseudo-random its hard to deterministically say one should win out during a tie!
I agree with you and that we can have another test that would keep running multiple auctions until both alice and bob winning a tie is tested out- but this test would need to be skipped in CI as it would take a lot of time
Tristan-Wilson
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes how we broke tie on the GO side and matches it to how the auction contract breaks it.
Resolves NIT-3132