Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setGateways() in OrbitGatewayRouter should not be payable #43

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

tsite
Copy link
Contributor

@tsite tsite commented Oct 3, 2023

This function uses the fee paying token instead of ETH for fees.

This function uses the fee paying token instead of ETH for fees
@cla-bot
Copy link

cla-bot bot commented Oct 3, 2023

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign one of the linked documents below to get yourself added. If you're an independent Individual please sign this form: https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=1353a816-a9c1-47ba-847e-ec79f0f23d31&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2. If you're with a company (corporate) please sign this form: https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=2b5fe8ba-51d4-4980-b4ee-605d66e675d4&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2. To agree to the CLA license, please fill out one of the attached forms.

@gzeoneth gzeoneth requested a review from gvladika October 3, 2023 13:54
Copy link
Contributor

@gvladika gvladika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@gzeoneth
Copy link
Member

gzeoneth commented Oct 4, 2023

@tsite please let us know if you have signed the cla

@tsite
Copy link
Contributor Author

tsite commented Oct 4, 2023

I signed the cla - not sure why it's not showing up, maybe it takes a couple days to register

@hkalodner
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Oct 4, 2023
@cla-bot
Copy link

cla-bot bot commented Oct 4, 2023

The cla-bot has been summoned, and re-checked this pull request!

@hkalodner
Copy link
Contributor

Sorry, had missed this. Should be good now

@gvladika gvladika merged commit 95b2c40 into OffchainLabs:erc20-based-bridge Oct 9, 2023
4 of 5 checks passed
@tsite tsite deleted the erc20-based-bridge branch October 9, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants