Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slither issues #80

Closed
wants to merge 4 commits into from
Closed

Slither issues #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
861e421
Keep only single IERC20Bridge interface definition
gvladika Feb 26, 2024
c5c261d
Keep only a single IERC20Inbox interface definition
gvladika Feb 26, 2024
02f56bd
Update triage db
gvladika Feb 26, 2024
bef59f6
Format json
gvladika Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions contracts/tokenbridge/ethereum/L1AtomicTokenBridgeCreator.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ import {TransparentUpgradeableProxy} from
"@openzeppelin/contracts/proxy/transparent/TransparentUpgradeableProxy.sol";
import {IAccessControlUpgradeable} from
"@openzeppelin/contracts-upgradeable/access/IAccessControlUpgradeable.sol";
import {IERC20Bridge} from "../libraries/IERC20Bridge.sol";

/**
* @title Layer1 token bridge creator
Expand Down Expand Up @@ -571,10 +572,6 @@ contract L1AtomicTokenBridgeCreator is Initializable, OwnableUpgradeable {
}
}

interface IERC20Bridge {
function nativeToken() external view returns (address);
}

interface IInboxProxyAdmin {
function getProxyAdmin() external view returns (address);
}
Expand Down
15 changes: 1 addition & 14 deletions contracts/tokenbridge/ethereum/L1TokenBridgeRetryableSender.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {TransparentUpgradeableProxy} from
"@openzeppelin/contracts/proxy/transparent/TransparentUpgradeableProxy.sol";
import {IERC20} from "@openzeppelin/contracts/token/ERC20/ERC20.sol";
import {SafeERC20} from "@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol";
import {IERC20Inbox} from "./L1ArbitrumMessenger.sol";

/**
* @title Token Bridge Retryable Ticket Sender
Expand Down Expand Up @@ -239,17 +240,3 @@ struct L2DeploymentAddresses {
address upgradeExecutor;
address multicall;
}

interface IERC20Inbox {
function createRetryableTicket(
address to,
uint256 l2CallValue,
uint256 maxSubmissionCost,
address excessFeeRefundAddress,
address callValueRefundAddress,
uint256 gasLimit,
uint256 maxFeePerGas,
uint256 tokenTotalFeeAmount,
bytes calldata data
) external returns (uint256);
}
Loading
Loading