Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy::doc_lazy_continuation lints #402

Merged

Conversation

waywardmonkeys
Copy link
Contributor

Rust 1.80 brought a new clippy lint that detected when itemized list entries didn't indent the lines after the first. Indent those lines to silence that warning.

@Ogeon
Copy link
Owner

Ogeon commented Jul 30, 2024

Thanks for taking the time to correct them! I see that a couple of other issues have popped up as well... 😬

Copy link

codspeed-hq bot commented Jul 30, 2024

CodSpeed Performance Report

Merging #402 will improve performances by 10.14%

Comparing waywardmonkeys:fix-clippy-doc-lazy-continuation-lints (08ea298) with master (8550250)

Summary

⚡ 1 improvements
✅ 45 untouched benchmarks

Benchmarks breakdown

Benchmark master waywardmonkeys:fix-clippy-doc-lazy-continuation-lints Change
multiply_3x3 316.7 ns 287.5 ns +10.14%

@Ogeon Ogeon added the internal An internal change that will not be shown in release notes label Jul 30, 2024
@Ogeon
Copy link
Owner

Ogeon commented Jul 30, 2024

The initial clippy step passed, so I will bypass the rest and fix them separately. I need to think about that syn MSRV issue a bit.

@Ogeon Ogeon merged commit 28307cc into Ogeon:master Jul 30, 2024
10 of 16 checks passed
@waywardmonkeys waywardmonkeys deleted the fix-clippy-doc-lazy-continuation-lints branch July 30, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal change that will not be shown in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants