Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework chromatic adaptation #407

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Rework chromatic adaptation #407

merged 1 commit into from
Aug 2, 2024

Conversation

Ogeon
Copy link
Owner

@Ogeon Ogeon commented Aug 1, 2024

This adds new traits and functions for chromatic adaptation and deprecates the old traits and types. The new system makes use of the Lms type and can produce a Matrix3 for reuse and composition with other conversions. It's also possible to use dynamic input and output white points, such as when white balancing a photo.

Closed Issues

Copy link

codspeed-hq bot commented Aug 1, 2024

CodSpeed Performance Report

Merging #407 will not alter performance

Comparing chromatic_adaptation (c9c7491) with master (0a69512)

Summary

✅ 47 untouched benchmarks

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 99.37500% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.81%. Comparing base (0a69512) to head (c9c7491).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   82.62%   82.81%   +0.19%     
==========================================
  Files         128      128              
  Lines       19688    19826     +138     
  Branches    19688    19826     +138     
==========================================
+ Hits        16267    16419     +152     
+ Misses       3315     3302      -13     
+ Partials      106      105       -1     
Components Coverage Δ
palette 82.87% <99.37%> (+0.20%) ⬆️
palette_derive 81.98% <ø> (ø)

@Ogeon Ogeon force-pushed the chromatic_adaptation branch from 02743ec to c9c7491 Compare August 1, 2024 11:49
@Ogeon Ogeon merged commit 39a9c7a into master Aug 2, 2024
20 checks passed
@Ogeon Ogeon deleted the chromatic_adaptation branch August 2, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve chromatic adaptation API
1 participant