Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TimeLogsPage styles & fix SprintSelect bugs: sprint 0 is not selectable, clicking next sprint selects sprint 10 #280

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Update TimeLogsPage styles & fix SprintSelect bugs: sprint 0 is not selectable, clicking next sprint selects sprint 10 #280

merged 4 commits into from
Apr 24, 2024

Conversation

ismomehdi
Copy link
Contributor

@ismomehdi ismomehdi commented Apr 23, 2024 •
edited
Loading

resolves #251
resolves #277

  • Also added some styles for TimeLogsPage, TimeLogChart & TagSelect.
  • Removed isMobileView() rendering logic as all this can be handled using CSS.
  • Added logic to hide SprintSelect nextSprint/previousSprint buttons if next/previous sprint doesn't exist.

@ismomehdi ismomehdi added the frontend development related to frontend label Apr 23, 2024
@ismomehdi ismomehdi self-assigned this Apr 23, 2024
@ismomehdi ismomehdi changed the title Update TimeLogsPage styles & fix SprintSelect bugs: sprint 0 is not selectable, clicking next sprint selects sprint 10 [WIP] Update TimeLogsPage styles & fix SprintSelect bugs: sprint 0 is not selectable, clicking next sprint selects sprint 10 Apr 24, 2024
@ismomehdi ismomehdi force-pushed the fix/sprint-select-bugs branch from c9d3bf2 to 893507e Compare April 24, 2024 18:29
@ismomehdi ismomehdi changed the title [WIP] Update TimeLogsPage styles & fix SprintSelect bugs: sprint 0 is not selectable, clicking next sprint selects sprint 10 Update TimeLogsPage styles & fix SprintSelect bugs: sprint 0 is not selectable, clicking next sprint selects sprint 10 Apr 24, 2024
miahro
miahro approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@miahro miahro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@miahro miahro merged commit 12a3ac2 into main Apr 24, 2024
3 checks passed
@miahro miahro deleted the fix/sprint-select-bugs branch April 24, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miahro miahro miahro approved these changes

Assignees

@ismomehdi ismomehdi

Labels
frontend development related to frontend
Projects
None yet
Milestone
No milestone
2 participants
@ismomehdi @miahro