Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed time calculation from characters per second to words per minute #107

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Changed time calculation from characters per second to words per minute #107

merged 2 commits into from
Jan 17, 2019

Conversation

MasterOfTheTiger
Copy link
Contributor

@MasterOfTheTiger MasterOfTheTiger commented Jan 15, 2019

I have changed the code to calculate the time to read to use words per minute rather than characters per second. The README.md file is also updated to reflect this change.

To do this I had to rewrite most of that function. The new code is commented similarly as before.

Note: you may want to change the default words per minute speed, because there is a pretty noticable discrepancy between the old calculation and the new.

@davidlday
Copy link
Collaborator

davidlday commented Jan 16, 2019

Visually inspected code. Changes look good, but I don't have time to test right now.

EDIT: Removed reference to issue 83. Issue needs clarification.

@MasterOfTheTiger
Copy link
Contributor Author

@davidlday I looked at that issue, and it seems like that one is referring to tracking user words per minute in writing.

@davidlday
Copy link
Collaborator

@MasterOfTheTiger Good point - I asked for clarification on the issue. Now I'm reading it both ways and I'm not sure which is right. 😕

@davidlday
Copy link
Collaborator

@MasterOfTheTiger - Please resolve the minor conflicts and I'll run tests. Thank you!

@MasterOfTheTiger
Copy link
Contributor Author

@danielbayley Conflicts are resolved now.

@davidlday davidlday merged commit 5cbe50d into OleMchls:master Jan 17, 2019
@MasterOfTheTiger
Copy link
Contributor Author

@davidlday When will the new changes be released for Atom?

@davidlday
Copy link
Collaborator

@MasterOfTheTiger Unfortunately, I don't. @OleMchls - thoughts?

@OleMchls
Copy link
Owner

OleMchls commented May 7, 2019

@MasterOfTheTiger Unfortunately, I don't. @OleMchls - thoughts?

I'll go over all pending issues/discussions today and cut a release afterwards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants