Leverage word-regex #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @davidlday it took me a while to get back into this project. And I am sorry for that. Because of a previous merge this branch now has conflicts. If you could resolve it, I'd be happy to merge it. |
|
@OleMchls - no worries! Conflicts resolved. |
|
Thank you very much @davidlday |
|
This was just released with 2.11.0 ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented use of word-regex package for parsing words. This should close #91. The word-regex package still counts contractions as two words, which I strongly disagree with, but I've opened an issue there to resolve.
I also added basic scope detection, as I needed to reduce links to text in Markdown to get an accurate word count. I tested against this repo's README, which when properly reduced to text comes out to 110 words. By the way, there are no contractions in the README :) The scope detection should help keep the number of options down in the future.