Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My hw01 #1

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

My hw01 #1

wants to merge 9 commits into from

Conversation

Oleh8
Copy link
Owner

@Oleh8 Oleh8 commented May 30, 2019

No description provided.

Copy link

@Sofasmile Sofasmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve comment
Where is the drawDiamond task?


public static int GameForecastCalculator(int teamAscore, int teamBscore, int teamAscoreGuess, int teamBscoreGuess) {

if (teamAscore == teamAscoreGuess && teamBscore == teamBscoreGuess) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ternary operator here

public class GameScore {

public static int GameForecastCalculator(int teamAscore, int teamBscore, int teamAscoreGuess, int teamBscoreGuess) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove redundant line

@@ -0,0 +1,11 @@
package hw.one;

public class Main {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this class?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To test other classes.


public class PowNumber {
public static double sqrtNum(int number) {
double result;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write
return number * number;
and delete
double result;

}

public static double cubeNum(int number) {
double result;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same

}
return result;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove redundant line

Oleh8 added 5 commits June 2, 2019 16:36
Task added
Task 01, 03 edited
Task added
Task 01, 03 edited
Task added
Task 01, 03 edited
Task added
Task 01, 03 edited
@@ -0,0 +1,33 @@
package hw.one;

public class DiamondBuilder {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this method doesn't work with even number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants