Upgrade to bitcoinj 0.17-alpha1, ConsensusJ 0.7.0-alpha1 #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: * Investigate possible intermittent failures in regTest * Review OmniAddressMainNetParams, OmniNetwork, etc. (It would be nice if bitcoinj had pluggable address formats and could have multiple address formats on the same network or something like that) * Look more thoroughly for use of deprecated methods * Output value issues, 2 ignored tests: BitcoinJTransactionBuilderSpec, EncodeMultisigSpec * Global/consistent use of OmniAddressParser (for those experimental features) * Convert OmniCore clients to use Network in constructors * Address(Key)DeserializerSpec null/wildcard network specifier issues in Jackson module * Migrate @ignore'd unit tests that are actually regTests to regTest
Especially NetworkParameters and related.
When bitcoinj/bitcoinj#3120 is merged and a new bitcoinj-0.17 version is released, we can remove the workaround.
|
Because this PR is large and contains 7 commits, I will use a "merge commit" to merge it. |
msgilligan
changed the title
dexX7
approved these changes
Jul 7, 2023
|
Thanks @dexx! Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
All TODOs are now either complete or deferred