Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multiple active tx21's per address #271

Closed

Conversation

marv-engine
Copy link

Updated tx21 Update & Cancel messages & behaviors

Marv Schneider added 3 commits October 9, 2014 16:34
Fix tx21 for Update & Cancel
Updated message & behavior for Update & Cancel sub-actions
no logical change, just more specific wording.
@dexX7
Copy link
Member

dexX7 commented Oct 10, 2014

I'm with @zathras on this one:

...reference the last 8 bytes of the tx hash, where we already have a unique sell offer identifier? We're talking about adding 16 bytes worth of fields in the proposed so it can't be tx space.

16 bytes to give #n and #y values to help us potentially locate the right offer
8 bytes (last 8 of tx hash) to give us exactly the right offer

@dacoinminster
Copy link
Contributor

See #270 for discussion.

Sorry Marv, I thought we had this settled. I hope we didn't just waste your time . . .

@dexX7
Copy link
Member

dexX7 commented Jul 2, 2019

Hi,

in an attempt to clean up the current specification, I'm going to close old and outstanding pull requests. Please note, it's tagged as "old idea", so the work is not wasted and we can potentially review it at some point later.

Please feel free to resubmit it as new pull request, if you still think it's a good idea.

@dexX7 dexX7 closed this Jul 2, 2019
@dexX7 dexX7 added the old idea label Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants