Skip to content
This repository has been archived by the owner on Feb 13, 2019. It is now read-only.

Multiple UI framework generator (includes Semantic) #571

Merged
merged 8 commits into from
Mar 14, 2016
Merged

Multiple UI framework generator (includes Semantic) #571

merged 8 commits into from
Mar 14, 2016

Conversation

jjwilliams42
Copy link
Contributor

This PR is in response to the discussion @spboyer, @sayedihashimi
and I had on Friday regarding jackjwilliams/generator-aspnet-semanticui. They were going to reach out to Google and other framework to see about other integrations, I was to submit a PR that demonstrates the ability to override with a ui framework, this one adds Semantic UI.

Changes

Thanks!

/cc
@OmniSharp/generator-aspnet-team-push

Changes
5bb4742 
- Add semantic.validation.min.js for consistency
- Add tests for Semantic UI overrides per jjwilliams42/generator-aspnet-semanticui#9 and jjwilliams42/generator-aspnet-semanticui#6
- Add <% namespace %> to _Layout.cshtml (missing)
- Remove title from MenuLinkTagHelper rendering per jjwilliams42/generator-aspnet-semanticui#5
- Remove commented out code and extra call to $('.class').checkbox() in Login.cshtml
- Remove commented out code in various cshtml files
- Merged in functionality to use Semantic OR Bootstrap libraries using yo menu selection or command line argument
@jjwilliams42
Copy link
Contributor Author

For developers, to add a new UI framework:

Include all css/js/config/cshtml files in the templates/overrides/uiframework/web and templates/overrides/uiframework/webbasic folders. Mimicking the typical ASP.NET folder structure, and adding any additional files / folders needed.

Add test coverage

Modify app/index.js UI Framework question to include your framework, ensuring that the value of the answer to the question is the exact same name as the templates/overrides/uiframework folder.

peterblazejewicz
peterblazejewicz reviewed Mar 6, 2016
View reviewed changes
README.md
@@ -1,10 +1,12 @@
# generator-aspnet

[![Join the chat at https://gitter.im/jackjwilliams/generator-aspnet-semanticui](https://badges.gitter.im/jackjwilliams/generator-aspnet-semanticui.svg)](https://gitter.im/jackjwilliams/generator-aspnet-semanticui?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not badge for this repo
👎
The OmniSharp has just its own Omnisharp general repo for issues/talks.

jjwilliams42 and others added 7 commits March 6, 2016 16:52
@jjwilliams42
Remove incorrect badge
60f3273
@jjwilliams42
Change description, forgot to remove "with Semantic UI"
f51eeaf
Changes
06ca069 
- Add summary for MenuLinkTagHelper
- Remove commented out code from VerifyCode.cshtml
- Add full protocol link to web and webbasic Home/Index.cshtml, _Layout.cshtml, _ValidationScriptsPartial.cshtml
- In _ValidationScriptsPartial.cshtml, change Production env to use semantic.validation.min.js
- web/webbasic override bower.json indentation fix
- In both _Layout.cshtml's (web and webbasic), add menu.header to be consistent with already available template.
- Fix missing <%= namespace %> in html head title of _Layout.cshtml's
- Use bootstraps .sr-only helper class for screenreaders. Add sr-only "Toggle Navigation" span for SR's.
- Flatten site.css indentation
- Update site.js code, add brackets to be consistent
- Add referenced https://github.com/aspnet/Mvc/issues/2369 so people are aware of different solutions to issues with label/checkbox
Merge branch 'master' of github.com:jackjwilliams/generator-aspnet
ad1742d
Left out TagHelper.cs remarks from webbasic project
445a89a
Changes
36090dd 
- site.css: Remove fix for wierd checkbox issue, turns out it works fine without it. Could have been a victim of late night coding.
Changes
c2afafe 
- Update base README.md, move extraneous info to ...
- Added README.md to be generated with web/webbasic project, with Semantic UI specific info.
@spboyer
Copy link
Contributor

spboyer commented Mar 13, 2016

@peterblazejewicz @jackjwilliams this is looking good, are the needed modifications complete?

@jjwilliams42
Copy link
Contributor Author

I've tended to all of Peter's remarks I believe. He may want to look over
once more. I think some more documentation might be needed on the wiki
possibly.

Thanks,
Josh
On Mar 13, 2016 6:39 PM, "Shayne Boyer" [email protected] wrote:

@peterblazejewicz https://github.com/peterblazejewicz @jackjwilliams
https://github.com/jackjwilliams this is looking good, are the needed
modifications complete?

—
Reply to this email directly or view it on GitHub
#571 (comment)
.

@peterblazejewicz
Copy link
Member

@spboyer
There are some minor tweaks to be done (in the markup alone, not in implementation). We can quickly iron it out later.
So good to go, it passes tests.

@spboyer
Copy link
Contributor

spboyer commented Mar 14, 2016

Im good with this then. I have reviewed all of the changes. @peterblazejewicz do you want to wait merge this and add the mdl option?

@peterblazejewicz
Copy link
Member

do you want to wait merge this and add the mdl option?

No. This one could go

spboyer added a commit that referenced this pull request Mar 14, 2016
@spboyer
Merge pull request #571 from jackjwilliams/master
7ebcab1 
Multiple UI framework generator (includes Semantic)
@spboyer spboyer merged commit 7ebcab1 into OmniSharp:master Mar 14, 2016
@spboyer
Copy link
Contributor

spboyer commented Mar 14, 2016

Nice add. Will do a release once the mdl option is in there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjwilliams42 @spboyer @peterblazejewicz