Issue #34 Enhance Docker Security and Best Practices #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a non-root user ('oba') in the OBA Dockerfile and switch to that user for improved security. This aligns with best practices for running Docker containers without superuser privileges. Ensure that the non-root user has the required permissions for the subsequent commands.
Introduce a non-root user ('oba') in the Bundler Dockerfile and switch to that user for enhanced security. Following Docker best practices reduces the risks associated with running containers as the root user. Confirm that the non-root user has the necessary permissions for the subsequent steps.
|
|
myselfdeepdas
changed the title
aaronbrethorst
requested changes
Feb 23, 2024
|
Check it out—I made some changes |
Neo2308
reviewed
Feb 25, 2024
| @@ -16,8 +19,6 @@ WORKDIR /oba/libs | |||
|
|
|||
| # OBA WAR and JAR files | |||
| RUN wget "https://repo.camsys-apps.com/releases/org/onebusaway/onebusaway-transit-data-federation-webapp/${OBA_VERSION}/onebusaway-transit-data-federation-webapp-${OBA_VERSION}.war" | |||
| RUN wget "https://repo.camsys-apps.com/releases/org/onebusaway/onebusaway-api-webapp/${OBA_VERSION}/onebusaway-api-webapp-${OBA_VERSION}.war" | |||
There was a problem hiding this comment.
@myselfdeepdas Removing these wget statements seems to be unintentional. Could you revert?
|
Superseded by #55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to enhance the security and follow best practices when running Docker containers for the OBA server and the transit data bundler.
Changes Made:
oba/Dockerfile:
bundler/Dockerfile:
Context:
The changes aim to minimize the potential security risks associated with running containers as the root user. Following best practices, we've created a dedicated non-root user for the containers, reducing the attack surface and enhancing the overall security posture.
Please review and merge these changes to ensure a more secure and reliable deployment of the OBA server and the transit data bundler containers.
Thank you!