Feat/add bing geocoder #186

Ahmedhossamdev · 2025-02-21T23:21:05Z

Fixes: #180

…ture

coveralls · 2025-02-21T23:22:46Z

coverage: 15.98% (+4.4%) from 11.602%
when pulling edef5fb on feat/add-bing-geocoder
into 57a49d4 on main.

aaronbrethorst

Looking good! There are a couple changes i'd like to see noted inline, plus I'd love to see some basic unit tests added for the new Bing methods.

src/lib/geocoder.js

aaronbrethorst

lgtm! 👍

Ahmedhossamdev added 3 commits February 20, 2025 19:20

Add Bing geocoding support

4b44e2c

Add support for using different geocoding provider in tripPlanner fea…

4b791bb

…ture

Fix formatting

ca39fa0

Ahmedhossamdev requested a review from aaronbrethorst February 21, 2025 23:40

aaronbrethorst requested changes Feb 22, 2025

View reviewed changes

src/lib/geocoder.js Outdated Show resolved Hide resolved

src/lib/geocoder.js Outdated Show resolved Hide resolved

Ahmedhossamdev added 3 commits February 22, 2025 03:24

feat: add helpers for consistent autocomplete and geocoding data

a02ef34

Add unit tests for geocoding functions (google & bing)

3f3510e

refactor: throw Error object for invalid geocoding provider

41f76ee

Ahmedhossamdev requested a review from aaronbrethorst February 22, 2025 01:57

refactor: remove unused import

edef5fb

aaronbrethorst approved these changes Feb 22, 2025

View reviewed changes

aaronbrethorst merged commit b720e87 into main Feb 22, 2025
4 checks passed

aaronbrethorst deleted the feat/add-bing-geocoder branch February 22, 2025 04:33

Provide feedback