Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cron job redesign #101

Merged
merged 8 commits into from
Sep 14, 2021
Merged

Cron job redesign #101

merged 8 commits into from
Sep 14, 2021

Conversation

SophiaWhiteMA
Copy link
Contributor

@SophiaWhiteMA SophiaWhiteMA commented Sep 9, 2021 •
edited
Loading

  • Cron jobs are now guaranteed to finish in a specific order (Cron jobs not guaranteed to completed in specific order #87)
  • Cron jobs now finish more quickly because the arbitrary time gaps between each job have been removed
  • The email queue proposed in emailSender function doesn't use a queue #91 has been added
  • Further refactoring using Promise.all is needed to make the current Cron jobs efficient at scale
  • Users are no longer penalized for not submitting enough hours if they're reactivated during the same day penalties are calculated
  • Cron jobs now all run 1 minute after midnight
  • Made eslint less strict to accommodate changes

@SophiaWhiteMA SophiaWhiteMA linked an issue Sep 9, 2021 that may be closed by this pull request
emailSender function doesn't use a queue #91
Closed
@SophiaWhiteMA SophiaWhiteMA merged commit d664b8a into development Sep 14, 2021
@calvertwong calvertwong deleted the cron_job_redesign branch September 22, 2021 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickTSA NickTSA NickTSA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

emailSender function doesn't use a queue
3 participants
@SophiaWhiteMA @NickTSA @CameronWhiteUFL