-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start date bug fix #2812
Open
anirudhsk2107
wants to merge
274
commits into
development
Choose a base branch
from
anirudhsk_fix_date_error_issue
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Start date bug fix #2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_modal_to_Permissions_Management_page
…_modal_to_Permissions_Management_page
…_modal_to_Permissions_Management_page
…ge with Flexbox adjustments and improved text wrapping.
…_to_be_created_and_redirected_to
…_implement_Default_Error_Page_to_be_created_and_redirected_to Revert "Peterson implement default error page to be created and redirected to"
…-And-Darkmode-Fix Dhrumil save message and darkmode fix
…erManagement Dhrumil - Added tests cases for UserManagement.
…teModal Aditya-Added-UnitTest-DeleteModal
Aditya-Added-Tests-For-Badges
Aditya-Added-Testing-for-Login
…-type-list Vedant Fix inventory type list, add sort and search functionality
…de_requirement_new_users Rishitha_Fix_team_code_requirement_new_users
…eview-button Sharadha Ready for Review Dropdown is Cropped
…_freeze Yili - Clicking active button cause the page to freeze
…g_fix Anne fix hovering in dark mode subtask get white issue for WBS tasks
…-dot-centering-on-Tasks-pages Swathi Fix resources dot centering on Tasks pages
…hours-editing-deleting Huijie fix add lost hours editing deleting
merge dev into my branch
…popup-issue Nikhil - fixed new user popup issue
…tion-pie-chart huijie role distribution pie chart for TotalOrgSummary
…eam-hours-visualization Carlos improvement team hours visualization
…eCommunityGlobal/HighestGoodNetworkApp into anirudhsk_fix_date_error_issue
anirudhsk2107
added
DO NOT MERGE
Don't merge PR
do not review
Do not review or look at code without full context
labels
Dec 3, 2024
anirudhsk2107
removed
DO NOT MERGE
Don't merge PR
do not review
Do not review or look at code without full context
labels
Dec 3, 2024
Hi @CodewithKoushica, @hqzhu0913 Thank you for your comments. I have addressed them in a separate PR. |
anirudhsk2107
added
the
do not review
Do not review or look at code without full context
label
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Navigate to Other Links → Projects → WBS → Click on WBS name → Add Task
Bug: When the End Date is set earlier than the Start Date, the error message 'Due Date must be greater than Start Date' appears for both fields, but it should only appear for the End Date.
Navigate to Other Links → Projects → WBS → Click on WBS name → Task Edit → Edit
Bug: When the Start Date and End Date are corrected in the Update Task modal (with the Start Date set earlier than the End Date), error messages are still displayed for both dates.
Navigate to Other Links → Projects → WBS → Click on WBS name → Task Edit → Edit
Bug: When the End Date is updated to a date earlier than the Start Date, I was able to save the incorrect updates despite the error messages being displayed.
Navigate to Other Links → Projects → WBS → Click on WBS name → Task Edit → Edit
Bug: When opening a task for editing with incorrectly set dates(see image above), the End Date appears as unspecified (the default date is shown in the End Date field in the image below).
The format of the Start Date does not match the format of the End Date in the Edit Task modal.
Related PRS (if any):
Not related to any backend PRs
Main changes explained:
How to test:
Screenshots or videos of changes:
StartDateErrorFix.mp4
Note:
The add task page can be navigated to here in this video
This PR is related to front end PR 2335. Same bugs were fixed in the Add Task modal.