Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start date bug fix #2812

Open
wants to merge 274 commits into
base: development
Choose a base branch
from
Open

Conversation

anirudhsk2107
Copy link

Description

  1. Navigate to Other Links → Projects → WBS → Click on WBS name → Add Task
    Bug: When the End Date is set earlier than the Start Date, the error message 'Due Date must be greater than Start Date' appears for both fields, but it should only appear for the End Date.
    Screen Shot 2024-10-23 at 9 28 17 PM

  2. Navigate to Other Links → Projects → WBS → Click on WBS name → Task Edit → Edit
    Bug: When the Start Date and End Date are corrected in the Update Task modal (with the Start Date set earlier than the End Date), error messages are still displayed for both dates.
    Screen Shot 2024-10-23 at 9 29 10 PM

  3. Navigate to Other Links → Projects → WBS → Click on WBS name → Task Edit → Edit
    Bug: When the End Date is updated to a date earlier than the Start Date, I was able to save the incorrect updates despite the error messages being displayed.
    Screen Shot 2024-10-23 at 9 30 33 PM

  4. Navigate to Other Links → Projects → WBS → Click on WBS name → Task Edit → Edit
    Bug: When opening a task for editing with incorrectly set dates(see image above), the End Date appears as unspecified (the default date is shown in the End Date field in the image below).
    The format of the Start Date does not match the format of the End Date in the Edit Task modal.
    Screen Shot 2024-10-23 at 9 31 11 PM

Related PRS (if any):

Not related to any backend PRs

Main changes explained:

  • Added error message validation in EditTaskModal.jsx for Start Date and End Date, ensuring users input correct date values.
  • Fixed error messages persisting on closing or minimizing the modal by resetting state and clearing errors using the useEffect hook.
  • Fixed the format issue for start date when clicking on "Edit"

How to test:

  1. Check into current branch
  2. Do npm install and run this PR locally
  3. Clear site data/cache
  4. Log as owner/admin user
  5. Go to dashboard→ Projects → WBS -> Select Task
  6. Edit any task (Add a new one if no tasks are available)
  7. Check if the edit allows the start date to be more than the end date.

Screenshots or videos of changes:

StartDateErrorFix.mp4

Note:

The add task page can be navigated to here in this video
This PR is related to front end PR 2335. Same bugs were fixed in the Add Task modal.

akshit0211 and others added 30 commits July 19, 2024 18:53
…ge with Flexbox adjustments and improved text wrapping.
one-community and others added 23 commits November 23, 2024 13:51
…_implement_Default_Error_Page_to_be_created_and_redirected_to

Revert "Peterson implement default error page to be created and redirected to"
…-And-Darkmode-Fix

Dhrumil save message and darkmode fix
…erManagement

Dhrumil - Added tests cases for UserManagement.
…teModal

Aditya-Added-UnitTest-DeleteModal
…-type-list

Vedant Fix inventory type list, add sort and search functionality
…de_requirement_new_users

Rishitha_Fix_team_code_requirement_new_users
…eview-button

Sharadha Ready for Review Dropdown is Cropped
…_freeze

Yili - Clicking active button cause the page to freeze
…g_fix

Anne fix hovering in dark mode subtask get white issue for WBS tasks
…-dot-centering-on-Tasks-pages

Swathi Fix resources dot centering on Tasks pages
…hours-editing-deleting

Huijie fix add lost hours editing deleting
…popup-issue

Nikhil - fixed new user popup issue
…tion-pie-chart

huijie role distribution pie chart for TotalOrgSummary
…eam-hours-visualization

Carlos improvement team hours visualization
@anirudhsk2107 anirudhsk2107 added DO NOT MERGE Don't merge PR do not review Do not review or look at code without full context labels Dec 3, 2024
@anirudhsk2107 anirudhsk2107 removed DO NOT MERGE Don't merge PR do not review Do not review or look at code without full context labels Dec 3, 2024
@anirudhsk2107
Copy link
Author

Hi @CodewithKoushica, @hqzhu0913

Thank you for your comments. I have addressed them in a separate PR.
Please review the PR mentioned below and ignore this PR
PR 2915

@anirudhsk2107 anirudhsk2107 added the do not review Do not review or look at code without full context label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not review Do not review or look at code without full context
Projects
None yet
Development

Successfully merging this pull request may close these issues.