-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weekly Volunteer Summary Dashboard Components #2974
Weekly Volunteer Summary Dashboard Components #2974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Sri. I've reviewed your PR and here are my requested changes:
Volunteer Status Pie chart
-
The background colors for the Active, New , and Deactivated portions need to be the same color as the corresponding tabs in the Volunteer Status component as shown in the Figma design:
-
The numbers should be centered and the title color black to match the design.
Volunteer Status and Activities
- No changes needed.
Blue Square Stats
- Figma design had an update to inlcude a "vacation time" category, and the color for the "Other" category has changed. Please add these in.
Team Stats chart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Sri. I looked into your changes and here's my feedback:
Volunteer Status Pie Chart
The pie chart was using the correct colors/hues before. I meant for you to keep the blue color with "New" and pink with "Deactivated" which I see is fixed now. Please update this to use the exact colors in the Figma (left of image). Apologies for the confusion.
The percentages are also missing parentheses.
Blue Square Stats
The "Other" category in the legend is missing its orange color. The corresponding portion in the chart should be orange instead of black as well with visible numbers on top.
The percentages in parentheses should be whole numbers, no decimals.
At smaller browser widths, the colored square for "Missing Both Hours & Summary" gets squashed.
I confirm the other changes I requested have been fixed. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Volunteer Status pie chart looks good now. I made a commit to fix the colors in that chart and the Blue Square Stats chart to match the Figma.
The legend in the Blue Square Stats chart does not follow the design now. Please fix so that the color swatches are squares to left of the text. Here's the Figma for your reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR: Update TotalOrgSummary and Related Components
Description
This PR updates the TotalOrgSummary component and its related child components to work with the new API structure. It improves the dashboard's data visualization capabilities and ensures compatibility with the latest backend changes.
Related PRs
This frontend PR is related to the backend PR 1062 (OneCommunityGlobal/HGNRest#1062).
For Reference Frontend PRs,
Note: The above 4 PRs MUST NOT BE MERGED. I created them with just UI in mind.
Main Changes Explained
How to Test
npm install
to install any new dependenciesnpm run dev
)Additional Notes