Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit national cloud text. #242

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

andrueastman
Copy link
Collaborator

This PR fixes microsoftgraph/msgraph-metadata#503

It omits the Cloud Deployments description when annotating types and methods in the metadata to improve the metadata quality.

ApiDoctor.Validation/DocFile.cs Outdated Show resolved Hide resolved
@baywet
Copy link
Member

baywet commented Nov 21, 2023

I don't think I have merge privileges on this repo, we'll need @BarryShehadeh 's help. Don't hesitate to ping him on teams if he doesn't follow up promptly, he is usually responsive but can be busy at times :)

@andrueastman andrueastman merged commit 4c2e80c into master Nov 21, 2023
5 checks passed
@andrueastman andrueastman deleted the andrueastman/nationalCloudText branch November 21, 2023 13:25
@andrueastman
Copy link
Collaborator Author

I don't think I have merge privileges on this repo, we'll need @BarryShehadeh 's help. Don't hesitate to ping him on teams if he doesn't follow up promptly, he is usually responsive but can be busy at times :)

Sorry @baywet, saw this too late. I do have the privileges to merge.

Happy to update anything in a separate PR in case of anything @BarryShehadeh

@baywet
Copy link
Member

baywet commented Nov 21, 2023

no need to bother him then, it was a small change. Didn't know you had the permission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud Deployments description appended in API Ref/Graph PowerShell docs resulting in broken experience
2 participants