Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure function in case newsletter categories are not enabled #1665

Merged

Conversation

Tschuppi81
Copy link
Contributor

@Tschuppi81 Tschuppi81 commented Jan 24, 2025

Newsletter: Adds option to notify admins if a user unsubscribes from the newsletter subscription list

TYPE: Feature
LINK: ogc-2037

Checklist

  • I have performed a self-review of my code
  • I considered adding a reviewer
  • I have updated the PO files
  • I made changes/features for org and town6
  • I have tested my code thoroughly by hand
    • I have tested sending mails
  • I have added tests for my changes/features

Copy link

linear bot commented Jan 24, 2025

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.74%. Comparing base (d2c4c7d) to head (b34c04d).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
src/onegov/org/forms/settings.py 80.00% 2 Missing ⚠️
src/onegov/org/views/newsletter.py 80.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/onegov/org/forms/newsletter.py 86.59% <100.00%> (+0.22%) ⬆️
src/onegov/org/models/organisation.py 98.00% <100.00%> (+1.51%) ⬆️
src/onegov/org/utils.py 85.64% <100.00%> (+0.06%) ⬆️
src/onegov/org/views/subscription.py 91.17% <100.00%> (+1.52%) ⬆️
src/onegov/org/views/newsletter.py 95.66% <80.00%> (-1.06%) ⬇️
src/onegov/org/forms/settings.py 80.76% <80.00%> (-0.06%) ⬇️

... and 220 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0942af...b34c04d. Read the comment docs.

@Tschuppi81 Tschuppi81 marked this pull request as ready for review January 24, 2025 14:52
src/onegov/org/forms/settings.py Outdated Show resolved Hide resolved
src/onegov/org/views/subscription.py Outdated Show resolved Hide resolved
src/onegov/town6/templates/mail_notify_unsubscribe.pt Outdated Show resolved Hide resolved
@Tschuppi81 Tschuppi81 merged commit 08e795f into master Jan 30, 2025
14 checks passed
@Tschuppi81 Tschuppi81 deleted the feature/ogc-2037-notify-admins-for-unsubscribing-newsletter branch January 30, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants