Fixing issues caught with address sanitizer #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SANITIZE` set to 1 will statically link all targets in the `src/` dir. This makes shared library shimming a bit less annoying (at the cost of bin size). Programs will not be haulted if ASAN detects anything weird. Instead a log file will be created as `.tmp_update/logs/ASAN.log.<PID>`.
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just freeing strings and closing files. None of these are too
severe. Changes should be fairly self explanatory but please ask if
something is not clear. I have my device running with these changes.
Also add in the changes needed for someone else to enable the sanitizer.
SANITIZEset to 1 will statically link all targets in thesrc/dir. This makes shared library shimming a bit less annoying (at
the cost of bin size).
Programs will not be haulted if ASAN detects anything weird. Instead
a log file will be created as
.tmp_update/logs/ASAN.log.<PID>.